Re: [RFC ipsec-next 1/8] iptfs: config: add CONFIG_XFRM_IPTFS

[Christian Hopps <chopps@labn.net>]

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]


Simon Horman <horms@kernel.org> writes:

> On Fri, Nov 10, 2023 at 06:37:12AM -0500, Christian Hopps wrote:
>> From: Christian Hopps <chopps@labn.net>
>>
>> Signed-off-by: Christian Hopps <chopps@labn.net>
>
> Hi Christian,
>
> thanks for your patchset.
> Some feedback from my side, I hope it is useful.
>
>> ---
>>  net/xfrm/Kconfig  | 9 +++++++++
>>  net/xfrm/Makefile | 1 +
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
>> index 3adf31a83a79..d07852069e68 100644
>> --- a/net/xfrm/Kconfig
>> +++ b/net/xfrm/Kconfig
>> @@ -134,6 +134,15 @@ config NET_KEY_MIGRATE
>>
>>  	  If unsure, say N.
>>
>> +config XFRM_IPTFS
>> +	bool "IPsec IPTFS (RFC 9347) encapsulation support"
>> +	depends on XFRM
>> +	help
>> +	  Information on the IPTFS encapsulation can be found
>> +          in RFC 9347.
>
> nit: the indentation of the above seems inconsistent

Yes, a spaces vs tabs issue, thanks fixed.

>> +
>> +          If unsure, say N.
>> +
>>  config XFRM_ESPINTCP
>>  	bool
>>
>> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
>> index cd47f88921f5..9b870a3274a7 100644
>> --- a/net/xfrm/Makefile
>> +++ b/net/xfrm/Makefile
>> @@ -20,4 +20,5 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>>  obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>>  obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>>  obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
>> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>>  obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
>
> Unfortunately, this breaks allmodconfig builds.

I've moved it to where the file is added in the last commit, thanks.

> Please ensure that each patch survives an allyesconfig and an allmodconfig
> build with W=1 set without new warnings or failures. [1].
>
> I also recommend checking that no new sparse warnings are introduced.

Ok, thanks,
Chris.

>
> [1] https://docs.kernel.org/process/maintainer-netdev.html#expected-level-of-testing


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 858 bytes --]