netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: drv-net: add missing trailing backslash
@ 2024-10-10 21:18 Jakub Kicinski
  2024-10-10 22:31 ` Joe Damato
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-10-10 21:18 UTC (permalink / raw)
  To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski

Commit b3ea416419c8 ("testing: net-drv: add basic shaper test")
removed the trailing backslash from the last entry. We have
a terminating comment here to avoid having to modify the last
line when adding at the end.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 tools/testing/selftests/drivers/net/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/drivers/net/Makefile b/tools/testing/selftests/drivers/net/Makefile
index 25aec5c081df..0fec8f9801ad 100644
--- a/tools/testing/selftests/drivers/net/Makefile
+++ b/tools/testing/selftests/drivers/net/Makefile
@@ -9,7 +9,7 @@ TEST_PROGS := \
 	ping.py \
 	queues.py \
 	stats.py \
-	shaper.py
+	shaper.py \
 # end of TEST_PROGS
 
 include ../../lib.mk
-- 
2.46.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] selftests: drv-net: add missing trailing backslash
  2024-10-10 21:18 [PATCH net-next] selftests: drv-net: add missing trailing backslash Jakub Kicinski
@ 2024-10-10 22:31 ` Joe Damato
  2024-10-11 10:43 ` Donald Hunter
  2024-10-11 23:10 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Joe Damato @ 2024-10-10 22:31 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni

On Thu, Oct 10, 2024 at 02:18:57PM -0700, Jakub Kicinski wrote:
> Commit b3ea416419c8 ("testing: net-drv: add basic shaper test")
> removed the trailing backslash from the last entry. We have
> a terminating comment here to avoid having to modify the last
> line when adding at the end.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  tools/testing/selftests/drivers/net/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/Makefile b/tools/testing/selftests/drivers/net/Makefile
> index 25aec5c081df..0fec8f9801ad 100644
> --- a/tools/testing/selftests/drivers/net/Makefile
> +++ b/tools/testing/selftests/drivers/net/Makefile
> @@ -9,7 +9,7 @@ TEST_PROGS := \
>  	ping.py \
>  	queues.py \
>  	stats.py \
> -	shaper.py
> +	shaper.py \
>  # end of TEST_PROGS
>  
>  include ../../lib.mk
> -- 

Reviewed-by: Joe Damato <jdamato@fastly.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] selftests: drv-net: add missing trailing backslash
  2024-10-10 21:18 [PATCH net-next] selftests: drv-net: add missing trailing backslash Jakub Kicinski
  2024-10-10 22:31 ` Joe Damato
@ 2024-10-11 10:43 ` Donald Hunter
  2024-10-11 23:10 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Donald Hunter @ 2024-10-11 10:43 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni

Jakub Kicinski <kuba@kernel.org> writes:

> Commit b3ea416419c8 ("testing: net-drv: add basic shaper test")
> removed the trailing backslash from the last entry. We have
> a terminating comment here to avoid having to modify the last
> line when adding at the end.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] selftests: drv-net: add missing trailing backslash
  2024-10-10 21:18 [PATCH net-next] selftests: drv-net: add missing trailing backslash Jakub Kicinski
  2024-10-10 22:31 ` Joe Damato
  2024-10-11 10:43 ` Donald Hunter
@ 2024-10-11 23:10 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-11 23:10 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 10 Oct 2024 14:18:57 -0700 you wrote:
> Commit b3ea416419c8 ("testing: net-drv: add basic shaper test")
> removed the trailing backslash from the last entry. We have
> a terminating comment here to avoid having to modify the last
> line when adding at the end.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: drv-net: add missing trailing backslash
    https://git.kernel.org/netdev/net-next/c/ec35b0c53cc7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-11 23:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-10 21:18 [PATCH net-next] selftests: drv-net: add missing trailing backslash Jakub Kicinski
2024-10-10 22:31 ` Joe Damato
2024-10-11 10:43 ` Donald Hunter
2024-10-11 23:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).