From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net] tools: ynl: avoid dict errors on older Python versions
Date: Thu, 25 May 2023 11:45:28 +0100 [thread overview]
Message-ID: <m28rdclmev.fsf@gmail.com> (raw)
In-Reply-To: <20230524170712.2036128-1-kuba@kernel.org> (Jakub Kicinski's message of "Wed, 24 May 2023 10:07:12 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> Python 3.9.0 or newer supports combining dicts() with |,
> but older versions of Python are still used in the wild
> (e.g. on CentOS 8, which goes EoL May 31, 2024).
> With Python 3.6.8 we get:
>
> TypeError: unsupported operand type(s) for |: 'dict' and 'dict'
>
> Use older syntax. Tested with non-legacy families only.
>
> Fixes: f036d936ca57 ("tools: ynl: Add fixed-header support to ynl")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
>
> This is arguably not a fix, but those trying YNL on 6.4 will likely
> appreciate not running into the problem.
I just hit the issue on Ubuntu on a BF2 so thank you for getting a fix
out before me! Tested with ovs_datapath.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Tested-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2023-05-25 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 17:07 [PATCH net] tools: ynl: avoid dict errors on older Python versions Jakub Kicinski
2023-05-25 8:29 ` Simon Horman
2023-05-25 10:45 ` Donald Hunter [this message]
2023-05-26 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28rdclmev.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).