Re: [PATCH net-next] tools: ynl: default to --process-unknown in installed mode

[Donald Hunter <donald.hunter@gmail.com>]

Jakub Kicinski <kuba@kernel.org> writes:

> We default to raising an exception when unknown attrs are found
> to make sure those are noticed during development.
> When YNL CLI is "installed" and used by sysadmins erroring out
> is not going to be helpful. It's far more likely the user space
> is older than the kernel in that case, than that some attr is
> misdefined or missing.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Good call.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

> ---
> CC: donald.hunter@gmail.com
> CC: jstancek@redhat.com
> ---
>  tools/net/ynl/pyynl/cli.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/net/ynl/pyynl/cli.py b/tools/net/ynl/pyynl/cli.py
> index 33ccc5c1843b..8c192e900bd3 100755
> --- a/tools/net/ynl/pyynl/cli.py
> +++ b/tools/net/ynl/pyynl/cli.py
> @@ -113,6 +113,8 @@ relative_schema_dir='../../../../Documentation/netlink'
>          spec = f"{spec_dir()}/{args.family}.yaml"
>          if args.schema is None and spec.startswith(sys_schema_dir):
>              args.schema = '' # disable schema validation when installed
> +        if args.process_unknown is None:
> +            args.process_unknown = True
>      else:
>          spec = args.spec
>      if not os.path.isfile(spec):