netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Donald Hunter <donald.hunter@gmail.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	 "Jonathan Corbet" <corbet@lwn.net>,
	 "Akira Yokosawa" <akiyks@gmail.com>,
	 "Breno Leitao" <leitao@debian.org>,
	 "David S. Miller" <davem@davemloft.net>,
	 "Ignacio Encinas Rubio" <ignacio@iencinas.com>,
	 "Marco Elver" <elver@google.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	 Eric Dumazet <edumazet@google.com>,
	 Paolo Abeni <pabeni@redhat.com>,
	joel@joelfernandes.org,  linux-kernel-mentees@lists.linux.dev,
	linux-kernel@vger.kernel.org,  lkmm@lists.linux.dev,
	netdev@vger.kernel.org,  peterz@infradead.org,
	 stern@rowland.harvard.edu
Subject: Re: [PATCH 3/4] docs: netlink: don't ignore generated rst files
Date: Wed, 11 Jun 2025 11:44:09 +0100	[thread overview]
Message-ID: <m2a56epngm.fsf@gmail.com> (raw)
In-Reply-To: <1cf12ab4c027cf27decf70a40aafdd0e2f669299.1749551140.git.mchehab+huawei@kernel.org>

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> Currently, the build system generates ReST files inside the
> source directory. This is not a good idea, specially when
> we have renames, as make clean won't get rid of them.

You're right that it's not a great idea, but it's the least bad option
with sphinx because it only supports 1 source dir. It doesn't have the
concept of a generated-sources dir and the alternative is to pollute the
output dir. See e.g. https://docs.kernel.org/media.h.rst

> As the first step to address the issue, stop ignoring those
> files. This way, we can see exactly what has been produced
> at build time inside $(srctree):
>
>         Documentation/networking/netlink_spec/conntrack.rst
>         Documentation/networking/netlink_spec/devlink.rst
>         Documentation/networking/netlink_spec/dpll.rst
>         Documentation/networking/netlink_spec/ethtool.rst
>         Documentation/networking/netlink_spec/fou.rst
>         Documentation/networking/netlink_spec/handshake.rst
>         Documentation/networking/netlink_spec/index.rst
>         Documentation/networking/netlink_spec/lockd.rst
>         Documentation/networking/netlink_spec/mptcp_pm.rst
>         Documentation/networking/netlink_spec/net_shaper.rst
>         Documentation/networking/netlink_spec/netdev.rst
>         Documentation/networking/netlink_spec/nfsd.rst
>         Documentation/networking/netlink_spec/nftables.rst
>         Documentation/networking/netlink_spec/nl80211.rst
>         Documentation/networking/netlink_spec/nlctrl.rst
>         Documentation/networking/netlink_spec/ovs_datapath.rst
>         Documentation/networking/netlink_spec/ovs_flow.rst
>         Documentation/networking/netlink_spec/ovs_vport.rst
>         Documentation/networking/netlink_spec/rt_addr.rst
>         Documentation/networking/netlink_spec/rt_link.rst
>         Documentation/networking/netlink_spec/rt_neigh.rst
>         Documentation/networking/netlink_spec/rt_route.rst
>         Documentation/networking/netlink_spec/rt_rule.rst
>         Documentation/networking/netlink_spec/tc.rst
>         Documentation/networking/netlink_spec/tcp_metrics.rst
>         Documentation/networking/netlink_spec/team.rst
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  Documentation/networking/netlink_spec/.gitignore | 1 -
>  1 file changed, 1 deletion(-)
>  delete mode 100644 Documentation/networking/netlink_spec/.gitignore
>
> diff --git a/Documentation/networking/netlink_spec/.gitignore b/Documentation/networking/netlink_spec/.gitignore
> deleted file mode 100644
> index 30d85567b592..000000000000
> --- a/Documentation/networking/netlink_spec/.gitignore
> +++ /dev/null
> @@ -1 +0,0 @@
> -*.rst

  reply	other threads:[~2025-06-11 11:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 10:46 [PATCH 0/4] Don't generate netlink .rst files inside $(srctree) Mauro Carvalho Chehab
2025-06-10 10:46 ` [PATCH 1/4] tools: ynl_gen_rst.py: create a top-level reference Mauro Carvalho Chehab
2025-06-10 10:46 ` [PATCH 2/4] docs: netlink: netlink-raw.rst: use :ref: instead of :doc: Mauro Carvalho Chehab
2025-06-10 10:46 ` [PATCH 3/4] docs: netlink: don't ignore generated rst files Mauro Carvalho Chehab
2025-06-11 10:44   ` Donald Hunter [this message]
2025-06-10 10:46 ` [PATCH 4/4] docs: netlink: store generated .rst files at Documentation/output Mauro Carvalho Chehab
2025-06-10 15:43   ` Breno Leitao
2025-06-10 20:59     ` Mauro Carvalho Chehab
2025-06-10 21:07       ` Jakub Kicinski
2025-06-12 14:39         ` Mauro Carvalho Chehab
2025-06-11 15:45     ` Mauro Carvalho Chehab
2025-06-11 15:55       ` Breno Leitao
2025-06-12 10:22         ` Mauro Carvalho Chehab
2025-06-11 11:36   ` Donald Hunter
2025-06-11 16:10     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a56epngm.fsf@gmail.com \
    --to=donald.hunter@gmail.com \
    --cc=akiyks@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elver@google.com \
    --cc=ignacio@iencinas.com \
    --cc=joel@joelfernandes.org \
    --cc=leitao@debian.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkmm@lists.linux.dev \
    --cc=mchehab+huawei@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).