netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] tools: ynl: add header guards for nlctrl
@ 2024-03-15  0:21 Jakub Kicinski
  2024-03-15 17:02 ` Donald Hunter
  2024-03-19 11:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-03-15  0:21 UTC (permalink / raw)
  To: davem
  Cc: netdev, edumazet, pabeni, Jakub Kicinski, jiri, chuck.lever,
	donald.hunter

I "extracted" YNL C into a GitHub repo to make it easier
to use in other projects: https://github.com/linux-netdev/ynl-c

GitHub actions use Ubuntu by default, and the kernel headers
there are missing f329a0ebeaba ("genetlink: correct uAPI defines").
Add the direct include workaround for nlctrl.

Fixes: 768e044a5fd4 ("doc/netlink/specs: Add spec for nlctrl netlink family")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
The Fixes tag is a bit unfair here, we never promised very
old headers will work. At the same time Ubuntu may be fairly
popular so seems worth making it work.
---
CC: jiri@resnulli.us
CC: chuck.lever@oracle.com
CC: donald.hunter@gmail.com
---
 tools/net/ynl/Makefile.deps | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
index 07373c5a7afe..f4e8eb79c1b8 100644
--- a/tools/net/ynl/Makefile.deps
+++ b/tools/net/ynl/Makefile.deps
@@ -20,6 +20,7 @@ CFLAGS_ethtool:=$(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h)
 CFLAGS_handshake:=$(call get_hdr_inc,_LINUX_HANDSHAKE_H,handshake.h)
 CFLAGS_mptcp_pm:=$(call get_hdr_inc,_LINUX_MPTCP_PM_H,mptcp_pm.h)
 CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
+CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h)
 CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
 CFLAGS_ovs_datapath:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
 CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] tools: ynl: add header guards for nlctrl
  2024-03-15  0:21 [PATCH net] tools: ynl: add header guards for nlctrl Jakub Kicinski
@ 2024-03-15 17:02 ` Donald Hunter
  2024-03-19 11:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Donald Hunter @ 2024-03-15 17:02 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, jiri, chuck.lever

Jakub Kicinski <kuba@kernel.org> writes:

> I "extracted" YNL C into a GitHub repo to make it easier
> to use in other projects: https://github.com/linux-netdev/ynl-c
>
> GitHub actions use Ubuntu by default, and the kernel headers
> there are missing f329a0ebeaba ("genetlink: correct uAPI defines").
> Add the direct include workaround for nlctrl.
>
> Fixes: 768e044a5fd4 ("doc/netlink/specs: Add spec for nlctrl netlink family")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] tools: ynl: add header guards for nlctrl
  2024-03-15  0:21 [PATCH net] tools: ynl: add header guards for nlctrl Jakub Kicinski
  2024-03-15 17:02 ` Donald Hunter
@ 2024-03-19 11:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-19 11:00 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, edumazet, pabeni, jiri, chuck.lever, donald.hunter

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 14 Mar 2024 17:21:08 -0700 you wrote:
> I "extracted" YNL C into a GitHub repo to make it easier
> to use in other projects: https://github.com/linux-netdev/ynl-c
> 
> GitHub actions use Ubuntu by default, and the kernel headers
> there are missing f329a0ebeaba ("genetlink: correct uAPI defines").
> Add the direct include workaround for nlctrl.
> 
> [...]

Here is the summary with links:
  - [net] tools: ynl: add header guards for nlctrl
    https://git.kernel.org/netdev/net/c/9966e329d675

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-19 11:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-15  0:21 [PATCH net] tools: ynl: add header guards for nlctrl Jakub Kicinski
2024-03-15 17:02 ` Donald Hunter
2024-03-19 11:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).