Re: [PATCH net v3 2/4] netlink: specs: rt_addr: fix get multi command name

[Donald Hunter <donald.hunter@gmail.com>]

Jakub Kicinski <kuba@kernel.org> writes:

> Command names should match C defines, codegens may depend on it.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Fixes: 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v3:
>  - fix the op name in the test
> v2: https://lore.kernel.org/20250402010300.2399363-3-kuba@kernel.org
> ---
>  Documentation/netlink/specs/rt_addr.yaml | 2 +-
>  tools/testing/selftests/net/rtnetlink.py | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml
> index 3bc9b6f9087e..1650dc3f091a 100644
> --- a/Documentation/netlink/specs/rt_addr.yaml
> +++ b/Documentation/netlink/specs/rt_addr.yaml
> @@ -169,7 +169,7 @@ protonum: 0
>            value: 20
>            attributes: *ifaddr-all
>      -
> -      name: getmaddrs
> +      name: getmulticast
>        doc: Get / dump IPv4/IPv6 multicast addresses.
>        attribute-set: addr-attrs
>        fixed-header: ifaddrmsg
> diff --git a/tools/testing/selftests/net/rtnetlink.py b/tools/testing/selftests/net/rtnetlink.py
> index 80950888800b..69436415d56e 100755
> --- a/tools/testing/selftests/net/rtnetlink.py
> +++ b/tools/testing/selftests/net/rtnetlink.py
> @@ -12,7 +12,7 @@ IPV4_ALL_HOSTS_MULTICAST = b'\xe0\x00\x00\x01'
>      At least the loopback interface should have this address.
>      """
>  
> -    addresses = rtnl.getmaddrs({"ifa-family": socket.AF_INET}, dump=True)
> +    addresses = rtnl.getmulticast({"ifa-family": socket.AF_INET}, dump=True)
>  
>      all_host_multicasts = [
>          addr for addr in addresses if addr['ifa-multicast'] == IPV4_ALL_HOSTS_MULTICAST

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>