From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: glommer@parallels.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, lizf@cn.fujitsu.com,
kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com,
paul@paulmenage.org, gthelen@google.com,
netdev@vger.kernel.org, linux-mm@kvack.org,
kirill@shutemov.name, avagin@parallels.com, devel@openvz.org
Subject: Re: [PATCH v7 0/8] Request for inclusion: tcp memory buffers
Date: Thu, 13 Oct 2011 19:12:29 -0700 [thread overview]
Message-ID: <m2d3e01fua.fsf@firstfloor.org> (raw)
In-Reply-To: <20111013.160031.605700447623532119.davem@davemloft.net> (David Miller's message of "Thu, 13 Oct 2011 16:00:31 -0400 (EDT)")
David Miller <davem@davemloft.net> writes:
>
> Make this evaluate into exactly the same exact code stream we have
> now when the memory cgroup feature is not in use, which will be the
> majority of users.
One possible way may be to guard it with static_branch() for
no limit per cgroup set. That should be as near as practically
possible to the original code.
BTW the thing that usually worries me more is the cache line behaviour
when the feature is in use. In the past some of the namespace patches
have created some extremly hot global cache lines, that hurt on larger
systems (for example the Unix socket regression from uid namespaces that
is still not completly fixed). It would be good to double check that all
important state is distributed properly.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-10-14 2:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 13:09 [PATCH v7 0/8] Request for inclusion: tcp memory buffers Glauber Costa
2011-10-13 13:09 ` [PATCH v7 1/8] Basic kernel memory functionality for the Memory Controller Glauber Costa
2011-10-13 13:09 ` [PATCH v7 2/8] socket: initial cgroup code Glauber Costa
2011-10-13 13:09 ` [PATCH v7 3/8] foundations of per-cgroup memory pressure controlling Glauber Costa
2011-10-13 13:09 ` [PATCH v7 4/8] per-cgroup tcp buffers control Glauber Costa
2011-10-13 13:09 ` [PATCH v7 5/8] per-netns ipv4 sysctl_tcp_mem Glauber Costa
2011-10-13 13:09 ` [PATCH v7 6/8] tcp buffer limitation: per-cgroup limit Glauber Costa
2011-10-13 13:09 ` [PATCH v7 7/8] Display current tcp memory allocation in kmem cgroup Glauber Costa
2011-10-13 13:09 ` [PATCH v7 8/8] Disable task moving when using kernel memory accounting Glauber Costa
2011-10-13 20:00 ` [PATCH v7 0/8] Request for inclusion: tcp memory buffers David Miller
2011-10-13 20:05 ` Glauber Costa
2011-10-13 20:08 ` David Miller
2011-10-13 20:12 ` David Miller
2011-10-13 20:14 ` Glauber Costa
2011-10-13 20:18 ` David Miller
2011-10-14 12:56 ` Glauber Costa
2011-10-19 21:09 ` David Miller
2011-10-13 20:16 ` David Miller
2011-10-13 20:23 ` Glauber Costa
2011-10-14 2:55 ` Valdis.Kletnieks
2011-10-14 2:12 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d3e01fua.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=avagin@parallels.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=paul@paulmenage.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).