From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next 1/2] tools: ynl: rename make hardclean -> distclean
Date: Mon, 04 Mar 2024 10:18:20 +0000 [thread overview]
Message-ID: <m2edcql2qb.fsf@gmail.com> (raw)
In-Reply-To: <20240301235609.147572-2-kuba@kernel.org> (Jakub Kicinski's message of "Fri, 1 Mar 2024 15:56:08 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> The make target to remove all generated files used to be called
> "hardclean" because it deleted files which were tracked by git.
> We no longer track generated user space files, so use the more
> common "distclean" name.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Nit: distclean should probably be added to the .PHONY target in all the
makefiles.
> ---
> tools/net/ynl/Makefile | 2 +-
> tools/net/ynl/generated/Makefile | 4 ++--
> tools/net/ynl/lib/Makefile | 2 +-
> tools/net/ynl/samples/Makefile | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
> index da1aa10bbcc3..1874296665e1 100644
> --- a/tools/net/ynl/Makefile
> +++ b/tools/net/ynl/Makefile
> @@ -11,7 +11,7 @@ samples: | lib generated
> $(MAKE) -C $@ ; \
> fi
>
> -clean hardclean:
> +clean distclean:
> @for dir in $(SUBDIRS) ; do \
> if [ -f "$$dir/Makefile" ] ; then \
> $(MAKE) -C $$dir $@; \
> diff --git a/tools/net/ynl/generated/Makefile b/tools/net/ynl/generated/Makefile
> index 7135028cb449..713f5fb9cc2d 100644
> --- a/tools/net/ynl/generated/Makefile
> +++ b/tools/net/ynl/generated/Makefile
> @@ -43,11 +43,11 @@ protos.a: $(OBJS)
> clean:
> rm -f *.o
>
> -hardclean: clean
> +distclean: clean
> rm -f *.c *.h *.a
>
> regen:
> @../ynl-regen.sh
>
> -.PHONY: all clean hardclean regen
> +.PHONY: all clean distclean regen
> .DEFAULT_GOAL: all
> diff --git a/tools/net/ynl/lib/Makefile b/tools/net/ynl/lib/Makefile
> index d2e50fd0a52d..2201dafc62b3 100644
> --- a/tools/net/ynl/lib/Makefile
> +++ b/tools/net/ynl/lib/Makefile
> @@ -18,7 +18,7 @@ ynl.a: $(OBJS)
> clean:
> rm -f *.o *.d *~
>
> -hardclean: clean
> +distclean: clean
> rm -f *.a
>
> %.o: %.c
> diff --git a/tools/net/ynl/samples/Makefile b/tools/net/ynl/samples/Makefile
> index 1d33e98e3ffe..3e81432f7b27 100644
> --- a/tools/net/ynl/samples/Makefile
> +++ b/tools/net/ynl/samples/Makefile
> @@ -28,7 +28,7 @@ $(BINS): ../lib/ynl.a ../generated/protos.a $(SRCS)
> clean:
> rm -f *.o *.d *~
>
> -hardclean: clean
> +distclean: clean
> rm -f $(BINS)
>
> .PHONY: all clean
next prev parent reply other threads:[~2024-03-04 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 23:56 [PATCH net-next 0/2] tools: ynl: clean up make clean Jakub Kicinski
2024-03-01 23:56 ` [PATCH net-next 1/2] tools: ynl: rename make hardclean -> distclean Jakub Kicinski
2024-03-04 10:18 ` Donald Hunter [this message]
2024-03-01 23:56 ` [PATCH net-next 2/2] tools: ynl: remove __pycache__ during clean Jakub Kicinski
2024-03-04 10:23 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2edcql2qb.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).