From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org, jstancek@redhat.com, liuhangbin@gmail.com,
matttbe@kernel.org
Subject: Re: [PATCH net] tools: ynl: don't install tests
Date: Wed, 07 Jan 2026 10:36:24 +0000 [thread overview]
Message-ID: <m2fr8hwvyv.fsf@gmail.com> (raw)
In-Reply-To: <20260106163426.1468943-1-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> make's install target is meant for installing the production
> artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool
> from under the main YNL install target. The install target
> under tests/ is retained in case someone wants the tests
> to be installed.
>
> Fixes: 308b7dee3e5c ("tools: ynl: add YNL test framework")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jstancek@redhat.com
> CC: liuhangbin@gmail.com
> CC: matttbe@kernel.org
> ---
> tools/net/ynl/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
> index 7736b492f559..c2f3e8b3f2ac 100644
> --- a/tools/net/ynl/Makefile
> +++ b/tools/net/ynl/Makefile
> @@ -51,7 +51,6 @@ install: libynl.a lib/*.h
> @echo -e "\tINSTALL pyynl"
> @pip install --prefix=$(DESTDIR)$(prefix) .
> @make -C generated install
> - @make -C tests install
>
> run_tests:
> @$(MAKE) -C tests run_tests
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2026-01-07 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 16:34 [PATCH net] tools: ynl: don't install tests Jakub Kicinski
2026-01-07 1:43 ` Hangbin Liu
2026-01-07 10:36 ` Donald Hunter [this message]
2026-01-08 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fr8hwvyv.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jstancek@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox