From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hajime Tazaki <thehajime@gmail.com>
Subject: Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().
Date: Tue, 14 Jul 2015 00:23:27 +0900
Message-ID: <m2fv4s5bf4.wl@gmail.com>
References: <55A3CAFA.3060404@miraclelinux.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=ISO-2022-JP
Cc: davem@davemloft.net, netdev@vger.kernel.org, ek@google.com
To: hideaki.yoshifuji@miraclelinux.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pa0-f52.google.com ([209.85.220.52]:33470 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751031AbbGMPXf (ORCPT
	<rfc822;netdev@vger.kernel.org>); Mon, 13 Jul 2015 11:23:35 -0400
Received: by padck2 with SMTP id ck2so44408363pad.0
        for <netdev@vger.kernel.org>; Mon, 13 Jul 2015 08:23:35 -0700 (PDT)
In-Reply-To: <55A3CAFA.3060404@miraclelinux.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


At Mon, 13 Jul 2015 23:28:10 +0900,
YOSHIFUJI Hideaki/吉藤英明 wrote:
> 
> Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when
> finding source address on specific interface.") did not properly
> update best source address available.  Plus, it introduced
> possible NULL pointer dereference.
> 
> Bug was reported by Erik Kline <ek@google.com>.
> Based on patch proposed by Hajime Tazaki <thehajime@gmail.com>.
> 
> Fixes: 9131f3de24db4dc12199aede7d931e6703e97f3b ("ipv6: Do not
> 	iterate over all interfaces when finding source address
> 	on specific interface.")
> Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>

all of my tests passed with the patch on 14fe22e: Revert
"ipv4: use skb coalescing in defragmentation".

thanks for the prompt fix !

Acked-by: Hajime Tazaki <thehajime@gmail.com>