From: Donald Hunter <donald.hunter@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next] netlink: specs: nftables: allow decode of default firewalld ruleset
Date: Mon, 02 Sep 2024 11:41:16 +0100 [thread overview]
Message-ID: <m2ikve2v8z.fsf@gmail.com> (raw)
In-Reply-To: <20240902085735.70137-1-fw@strlen.de> (Florian Westphal's message of "Mon, 2 Sep 2024 10:57:31 +0200")
Florian Westphal <fw@strlen.de> writes:
> This update allows listing default firewalld ruleset on Fedora 40 via
> tools/net/ynl/cli.py --spec \
> Documentation/netlink/specs/nftables.yaml --dump getrule
>
> Default ruleset uses fib, reject and objref expressions which were
> missing.
>
> Other missing expressions can be added later.
>
> Improve decoding while at it:
> - add bitwise, ct and lookup attributes
> - wire up the quota expression
> - translate raw verdict codes to a human reable name, e.g.
> 'code': 4294967293 becomes 'code': 'jump'.
>
> Cc: Donald Hunter <donald.hunter@gmail.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
One minor question below, otherwise LGTM.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
> + name: fib-result
> + type: enum
> + entries:
> + - oif
> + - oifname
Did you intentionally leave out addrtype from the enum?
next prev parent reply other threads:[~2024-09-02 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 8:57 [PATCH net-next] netlink: specs: nftables: allow decode of default firewalld ruleset Florian Westphal
2024-09-02 10:41 ` Donald Hunter [this message]
2024-09-02 11:22 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ikve2v8z.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).