From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 1/3] tools: ynl: correctly handle overrides of fields in subset
Date: Tue, 07 Jan 2025 10:53:59 +0000 [thread overview]
Message-ID: <m2jzb6nbco.fsf@gmail.com> (raw)
In-Reply-To: <20250107022820.2087101-2-kuba@kernel.org> (Jakub Kicinski's message of "Mon, 6 Jan 2025 18:28:18 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> We stated in documentation [1] and previous discussions [2]
> that the need for overriding fields in members of subsets
> is anticipated. Implement it.
>
> Since each attr is now a new object we need to make sure
> that the modifications are propagated. Specifically C codegen
> wants to annotate which attrs are used in requests and replies
> to generate the right validation artifacts.
>
> [1] https://docs.kernel.org/next/userspace-api/netlink/specs.html#subset-of
> [2] https://lore.kernel.org/netdev/20231004171350.1f59cd1d@kernel.org/
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2025-01-07 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 2:28 [PATCH net-next v2 0/3] tools: ynl: decode link types present in tests Jakub Kicinski
2025-01-07 2:28 ` [PATCH net-next v2 1/3] tools: ynl: correctly handle overrides of fields in subset Jakub Kicinski
2025-01-07 10:53 ` Donald Hunter [this message]
2025-01-07 2:28 ` [PATCH net-next v2 2/3] tools: ynl: print some information about attribute we can't parse Jakub Kicinski
2025-01-07 2:28 ` [PATCH net-next v2 3/3] netlink: specs: rt_link: decode ip6tnl, vti and vti6 link attrs Jakub Kicinski
2025-01-08 2:20 ` [PATCH net-next v2 0/3] tools: ynl: decode link types present in tests patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2jzb6nbco.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).