From: Donald Hunter <donald.hunter@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
donald.hunter@redhat.com, Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management
Date: Tue, 05 Nov 2024 15:28:29 +0000 [thread overview]
Message-ID: <m2ldxxvgwy.fsf@gmail.com> (raw)
In-Reply-To: <ZyotMdGb23YbCBiK@shredder> (Ido Schimmel's message of "Tue, 5 Nov 2024 16:35:29 +0200")
Ido Schimmel <idosch@nvidia.com> writes:
> On Tue, Nov 05, 2024 at 12:28:31PM +0000, Donald Hunter wrote:
>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
>
> One question below (didn't notice it before)
>
> [...]
>
>> + -
>> + name: getrule
>> + doc: Dump all FIB rules
>> + attribute-set: fib-rule-attrs
>> + dump:
>> + request:
>> + value: 34
>> + attributes:
>> + - nsid
>
> What is the significance of 'nsid' here?
Hmm, looks like a couple of lines I need to remove.
Thanks for catching this!
prev parent reply other threads:[~2024-11-05 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 12:28 [PATCH net-next v2 0/2] netlink: specs: Add neigh and rule YNL specs Donald Hunter
2024-11-05 12:28 ` [PATCH net-next v2 1/2] netlink: specs: Add a spec for neighbor tables in rtnetlink Donald Hunter
2024-11-05 12:28 ` [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management Donald Hunter
2024-11-05 14:35 ` Ido Schimmel
2024-11-05 15:28 ` Donald Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ldxxvgwy.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).