From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com,
nicolas.dichtel@6wind.com, willemb@google.com
Subject: Re: [PATCH net] tools: ynl: fix handling of multiple mcast groups
Date: Tue, 27 Feb 2024 13:35:50 +0000 [thread overview]
Message-ID: <m2le76m3m1.fsf@gmail.com> (raw)
In-Reply-To: <20240226214019.1255242-1-kuba@kernel.org> (Jakub Kicinski's message of "Mon, 26 Feb 2024 13:40:18 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> We never increment the group number iterator, so all groups
> get recorded into index 0 of the mcast_groups[] array.
>
> As a result YNL can only handle using the last group.
> For example using the "netdev" sample on kernel with
> page pool commands results in:
>
> $ ./samples/netdev
> YNL: Multicast group 'mgmt' not found
>
> Most families have only one multicast group, so this hasn't
> been noticed. Plus perhaps developers usually test the last
> group which would have worked.
>
> Fixes: 86878f14d71a ("tools: ynl: user space helpers")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2024-02-27 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 21:40 [PATCH net] tools: ynl: fix handling of multiple mcast groups Jakub Kicinski
2024-02-27 13:35 ` Donald Hunter [this message]
2024-02-27 16:41 ` Nicolas Dichtel
2024-02-28 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2le76m3m1.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).