From: Changli Gao <xiaosuo@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Tom Herbert <therbert@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH] fix potential wild pointer when NIC is dying
Date: Wed, 14 Apr 2010 12:24:22 +0800 [thread overview]
Message-ID: <m2m412e6f7f1004132124y9ff2eeddwa2bbcaaa5d1f894f@mail.gmail.com> (raw)
In-Reply-To: <1271218986.1555.29.camel@Joe-Laptop.home>
On Wed, Apr 14, 2010 at 12:23 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2010-04-14 at 20:18 +0800, Changli Gao wrote:
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index a10a216..fe4a821 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
> []
>> -static void flush_backlog(void *arg)
>> +static int flush_backlog(void *arg)
>
> Why change this to return int?
>
>> + return 0;
>
> It seems to always return 0.
>
>
Keep stop_machine() happy.
int stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus);
--
Regards，
Changli Gao(xiaosuo@gmail.com)
next prev parent reply other threads:[~2010-04-14 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 12:18 [PATCH] fix potential wild pointer when NIC is dying Changli Gao
2010-04-14 4:23 ` Joe Perches
2010-04-14 4:24 ` Changli Gao [this message]
2010-04-14 5:33 ` Eric Dumazet
2010-04-14 7:25 ` Changli Gao
2010-04-14 7:49 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2m412e6f7f1004132124y9ff2eeddwa2bbcaaa5d1f894f@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox