[PATCH net-next] tools: ynl-gen: support uint in multi-attr

[PATCH net-next] tools: ynl-gen: support uint in multi-attr

[Jakub Kicinski]

The ethtool FEC histogram series run into a build issue with
type: uint + multi-attr: True. Auto scalars use 64b types,
we need to convert them explicitly when rendering the types.

No current spec needs this, and the ethtool FEC histogram
doesn't need this either any more, so not posting as a fix.

Link: https://lore.kernel.org/8f52c5b8-bd8a-44b8-812c-4f30d50f63ff@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: donald.hunter@gmail.com
CC: jacob.e.keller@intel.com
---
 tools/net/ynl/pyynl/ynl_gen_c.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
index 56c63022d702..58086b101057 100755
--- a/tools/net/ynl/pyynl/ynl_gen_c.py
+++ b/tools/net/ynl/pyynl/ynl_gen_c.py
@@ -720,7 +720,11 @@ from lib import SpecSubMessage
             return 'struct ynl_string *'
         elif self.attr['type'] in scalars:
             scalar_pfx = '__' if ri.ku_space == 'user' else ''
-            return scalar_pfx + self.attr['type']
+            if self.is_auto_scalar:
+                name = self.type[0] + '64'
+            else:
+                name = self.attr['type']
+            return scalar_pfx + name
         else:
             raise Exception(f"Sub-type {self.attr['type']} not supported yet")
 
-- 
2.51.0

Re: [PATCH net-next] tools: ynl-gen: support uint in multi-attr

[Vadim Fedorenko]

On 16/09/2025 18:04, Jakub Kicinski wrote:
> The ethtool FEC histogram series run into a build issue with
> type: uint + multi-attr: True. Auto scalars use 64b types,
> we need to convert them explicitly when rendering the types.
> 
> No current spec needs this, and the ethtool FEC histogram
> doesn't need this either any more, so not posting as a fix.
> 
> Link: https://lore.kernel.org/8f52c5b8-bd8a-44b8-812c-4f30d50f63ff@redhat.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jacob.e.keller@intel.com
> ---
>   tools/net/ynl/pyynl/ynl_gen_c.py | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
> index 56c63022d702..58086b101057 100755
> --- a/tools/net/ynl/pyynl/ynl_gen_c.py
> +++ b/tools/net/ynl/pyynl/ynl_gen_c.py
> @@ -720,7 +720,11 @@ from lib import SpecSubMessage
>               return 'struct ynl_string *'
>           elif self.attr['type'] in scalars:
>               scalar_pfx = '__' if ri.ku_space == 'user' else ''
> -            return scalar_pfx + self.attr['type']
> +            if self.is_auto_scalar:
> +                name = self.type[0] + '64'
> +            else:
> +                name = self.attr['type']
> +            return scalar_pfx + name
>           else:
>               raise Exception(f"Sub-type {self.attr['type']} not supported yet")
>   

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

Re: [PATCH net-next] tools: ynl-gen: support uint in multi-attr

[Donald Hunter]

Jakub Kicinski <kuba@kernel.org> writes:

> The ethtool FEC histogram series run into a build issue with
> type: uint + multi-attr: True. Auto scalars use 64b types,
> we need to convert them explicitly when rendering the types.
>
> No current spec needs this, and the ethtool FEC histogram
> doesn't need this either any more, so not posting as a fix.
>
> Link: https://lore.kernel.org/8f52c5b8-bd8a-44b8-812c-4f30d50f63ff@redhat.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jacob.e.keller@intel.com

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

Re: [PATCH net-next] tools: ynl-gen: support uint in multi-attr

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 16 Sep 2025 10:04:31 -0700 you wrote:
> The ethtool FEC histogram series run into a build issue with
> type: uint + multi-attr: True. Auto scalars use 64b types,
> we need to convert them explicitly when rendering the types.
> 
> No current spec needs this, and the ethtool FEC histogram
> doesn't need this either any more, so not posting as a fix.
> 
> [...]

Here is the summary with links:
  - [net-next] tools: ynl-gen: support uint in multi-attr
    https://git.kernel.org/netdev/net-next/c/4436b2b324ce

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html