From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Herbert Subject: Re: rps perfomance WAS(Re: rps: question Date: Sat, 17 Apr 2010 10:26:14 -0700 Message-ID: References: <4BC741AE.3000108@hp.com> <1271362581.23780.12.camel@bigi> <1271395106.16881.3645.camel@edumazet-laptop> <1271424065.4606.31.camel@bigi> <1271489739.16881.4586.camel@edumazet-laptop> <1271496229.16881.4602.camel@edumazet-laptop> <1271514445.16881.4746.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: hadi@cyberus.ca, Changli Gao , Rick Jones , David Miller , netdev@vger.kernel.org, robert@herjulf.net, andi@firstfloor.org To: Eric Dumazet Return-path: Received: from smtp-out.google.com ([74.125.121.35]:15299 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748Ab0DQR0T (ORCPT ); Sat, 17 Apr 2010 13:26:19 -0400 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id o3HHQGG0025412 for ; Sat, 17 Apr 2010 19:26:17 +0200 Received: from pwj4 (pwj4.prod.google.com [10.241.219.68]) by wpaz5.hot.corp.google.com with ESMTP id o3HHQF66013834 for ; Sat, 17 Apr 2010 10:26:15 -0700 Received: by pwj4 with SMTP id 4so2691211pwj.36 for ; Sat, 17 Apr 2010 10:26:15 -0700 (PDT) In-Reply-To: <1271514445.16881.4746.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: > Tom, I am not sure what you describe is even respected for NAPI devices. > (I hope you use napi devices in your company ;) ) > > If we enqueue a skb to backlog, we also link our backlog napi into our > poll_list, if not already there. > > So the loop in net_rx_action() will make us handle our backlog napi a > bit after this network device napi (if time limit of 2 jiffies not > elapsed) and *before* sending IPIS to remote cpus anyway. > Then I think that's a bug you've identified ;-) > > > >