From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org, jacob.e.keller@intel.com, sdf@fomichev.me,
jdamato@fastly.com
Subject: Re: [PATCH net-next v2 06/12] tools: ynl-gen: support CRUD-like notifications for classic Netlink
Date: Fri, 25 Apr 2025 10:21:16 +0100 [thread overview]
Message-ID: <m2plh0r3zn.fsf@gmail.com> (raw)
In-Reply-To: <20250425024311.1589323-7-kuba@kernel.org> (Jakub Kicinski's message of "Thu, 24 Apr 2025 19:43:05 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> Allow CRUD-style notification where the notification is more
> like the response to the request, which can optionally be
> looped back onto the requesting socket. Since the notification
> and request are different ops in the spec, for example:
>
> -
> name: delrule
> doc: Remove an existing FIB rule
> attribute-set: fib-rule-attrs
> do:
> request:
> value: 33
> attributes: *fib-rule-all
> -
> name: delrule-ntf
> doc: Notify a rule deletion
> value: 33
> notify: getrule
>
> We need to find the request by ID. Ideally we'd detect this model
> from the spec properties, rather than assume that its what all
> classic netlink families do. But maybe that'd cause this model
> to spread and its easy to get wrong. For now assume CRUD == classic.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2025-04-29 9:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 2:42 [PATCH net-next v2 00/12] tools: ynl-gen: additional C types and classic netlink handling Jakub Kicinski
2025-04-25 2:43 ` [PATCH net-next v2 01/12] tools: ynl-gen: fix comment about nested struct dict Jakub Kicinski
2025-04-25 9:08 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 02/12] tools: ynl-gen: factor out free_needs_iter for a struct Jakub Kicinski
2025-04-25 9:09 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 03/12] tools: ynl-gen: fill in missing empty attr lists Jakub Kicinski
2025-04-25 9:12 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 04/12] tools: ynl: let classic netlink requests specify extra nlflags Jakub Kicinski
2025-04-25 9:15 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 05/12] tools: ynl-gen: support using dump types for ntf Jakub Kicinski
2025-04-25 9:16 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 06/12] tools: ynl-gen: support CRUD-like notifications for classic Netlink Jakub Kicinski
2025-04-25 9:21 ` Donald Hunter [this message]
2025-04-25 2:43 ` [PATCH net-next v2 07/12] tools: ynl-gen: multi-attr: type gen for string Jakub Kicinski
2025-04-25 9:26 ` Donald Hunter
2025-04-25 17:21 ` Simon Horman
2025-04-25 2:43 ` [PATCH net-next v2 08/12] tools: ynl-gen: mutli-attr: support binary types with struct Jakub Kicinski
2025-04-25 9:27 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 09/12] tools: ynl-gen: array-nest: support put for scalar Jakub Kicinski
2025-04-25 9:48 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 10/12] tools: ynl-gen: array-nest: support binary array with exact-len Jakub Kicinski
2025-04-25 9:56 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 11/12] tools: ynl-gen: don't init enum checks for classic netlink Jakub Kicinski
2025-04-25 10:04 ` Donald Hunter
2025-04-25 2:43 ` [PATCH net-next v2 12/12] tools: ynl: allow fixed-header to be specified per op Jakub Kicinski
2025-04-25 10:08 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2plh0r3zn.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).