Re: [PATCH] tools/Makefile: Add ynl target

[Donald Hunter <donald.hunter@gmail.com>]

Joe Damato <jdamato@fastly.com> writes:

> Add targets to build, clean, and install ynl headers, libynl.a, and
> python tooling.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---
>  tools/Makefile | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 5e1254eb66de..c31cbbd12c45 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -41,6 +41,7 @@ help:
>  	@echo '  mm                     - misc mm tools'
>  	@echo '  wmi			- WMI interface examples'
>  	@echo '  x86_energy_perf_policy - Intel energy policy tool'
> +	@echo '  ynl			- ynl headers, library, and python tool'
>  	@echo ''
>  	@echo 'You can do:'
>  	@echo ' $$ make -C tools/ <tool>_install'
> @@ -118,11 +119,14 @@ freefall: FORCE
>  kvm_stat: FORCE
>  	$(call descend,kvm/$@)
>  
> +ynl: FORCE
> +	$(call descend,net/ynl)
> +
>  all: acpi counter cpupower gpio hv firewire \
>  		perf selftests bootconfig spi turbostat usb \
>  		virtio mm bpf x86_energy_perf_policy \
>  		tmon freefall iio objtool kvm_stat wmi \
> -		debugging tracing thermal thermometer thermal-engine
> +		debugging tracing thermal thermometer thermal-engine ynl
>  
>  acpi_install:
>  	$(call descend,power/$(@:_install=),install)
> @@ -157,13 +161,16 @@ freefall_install:
>  kvm_stat_install:
>  	$(call descend,kvm/$(@:_install=),install)
>  
> +ynl_install:
> +	$(call descend,net/$(@:_install=),install)

nit: I'm not sure there's any merit in the $(@:_install=) construct,
when it's only really needed when there are multiple targets in the same
rule. For ynl_install, $(call descend,net/ynl,install) would be just
fine. It's funny that the existing convention in this Makefile is to
mostly use substitution for the _install rules, but literals for the
_clean rules.

Either way:

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

> +
>  install: acpi_install counter_install cpupower_install gpio_install \
>  		hv_install firewire_install iio_install \
>  		perf_install selftests_install turbostat_install usb_install \
>  		virtio_install mm_install bpf_install x86_energy_perf_policy_install \
>  		tmon_install freefall_install objtool_install kvm_stat_install \
>  		wmi_install debugging_install intel-speed-select_install \
> -		tracing_install thermometer_install thermal-engine_install
> +		tracing_install thermometer_install thermal-engine_install ynl_install
>  
>  acpi_clean:
>  	$(call descend,power/acpi,clean)
> @@ -214,12 +221,15 @@ freefall_clean:
>  build_clean:
>  	$(call descend,build,clean)
>  
> +ynl_clean:
> +	$(call descend,net/$(@:_clean=),clean)
> +
>  clean: acpi_clean counter_clean cpupower_clean hv_clean firewire_clean \
>  		perf_clean selftests_clean turbostat_clean bootconfig_clean spi_clean usb_clean virtio_clean \
>  		mm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \
>  		freefall_clean build_clean libbpf_clean libsubcmd_clean \
>  		gpio_clean objtool_clean leds_clean wmi_clean firmware_clean debugging_clean \
>  		intel-speed-select_clean tracing_clean thermal_clean thermometer_clean thermal-engine_clean \
> -		sched_ext_clean
> +		sched_ext_clean ynl_clean
>  
>  .PHONY: FORCE
>
> base-commit: 45bd443bfd8697a7da308c16c3e75e2bb353b3d1