From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next 1/3] netlink: specs: ovs: remove fixed header fields from attrs
Date: Thu, 14 Dec 2023 08:40:03 +0000 [thread overview]
Message-ID: <m2sf455g9o.fsf@gmail.com> (raw)
In-Reply-To: <20231213232822.2950853-2-kuba@kernel.org> (Jakub Kicinski's message of "Wed, 13 Dec 2023 15:28:20 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> Op's "attributes" list is a workaround for families with a single
> attr set. We don't want to render a single huge request structure,
> the same for each op since we know that most ops accept only a small
> set of attributes. "Attributes" list lets us narrow down the attributes
> to what op acctually pays attention to.
>
> It doesn't make sense to put names of fixed headers in there.
> They are not "attributes" and we can't really narrow down the struct
> members.
>
> Remove the fixed header fields from attrs for ovs families
> in preparation for C codegen support.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2023-12-14 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 23:28 [PATCH net-next 0/3] netlink: specs: prep legacy specs for C code gen Jakub Kicinski
2023-12-13 23:28 ` [PATCH net-next 1/3] netlink: specs: ovs: remove fixed header fields from attrs Jakub Kicinski
2023-12-14 8:40 ` Donald Hunter [this message]
2023-12-13 23:28 ` [PATCH net-next 2/3] netlink: specs: ovs: correct enum names in specs Jakub Kicinski
2023-12-14 8:45 ` Donald Hunter
2023-12-13 23:28 ` [PATCH net-next 3/3] netlink: specs: mptcp: rename the MPTCP path management(?) spec Jakub Kicinski
2023-12-13 23:38 ` Mat Martineau
2023-12-14 8:42 ` Donald Hunter
2023-12-14 17:24 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sf455g9o.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).