From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next 2/3] netlink: specs: add ovs_vport new command
Date: Tue, 15 Aug 2023 09:06:56 +0100 [thread overview]
Message-ID: <m2sf8kk9un.fsf@gmail.com> (raw)
In-Reply-To: <20230814205627.2914583-3-kuba@kernel.org> (Jakub Kicinski's message of "Mon, 14 Aug 2023 13:56:26 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> Add NEW to the spec, it was useful testing the fix for OvS
> input validation.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> ---
> Documentation/netlink/specs/ovs_vport.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/netlink/specs/ovs_vport.yaml b/Documentation/netlink/specs/ovs_vport.yaml
> index 17336455bec1..ef298b001445 100644
> --- a/Documentation/netlink/specs/ovs_vport.yaml
> +++ b/Documentation/netlink/specs/ovs_vport.yaml
> @@ -81,6 +81,10 @@ uapi-header: linux/openvswitch.h
> name-prefix: ovs-vport-attr-
> enum-name: ovs-vport-attr
> attributes:
> + -
> + name: unspec
> + type: unused
> + value: 0
> -
> name: port-no
> type: u32
> @@ -120,6 +124,20 @@ uapi-header: linux/openvswitch.h
> operations:
> name-prefix: ovs-vport-cmd-
> list:
> + -
> + name: new
> + doc: Create a new OVS vport
> + attribute-set: vport
> + fixed-header: ovs-header
> + do:
> + request:
> + attributes:
> + - name
> + - type
> + - upcall-pid
> + - dp-ifindex
> + - ifindex
> + - options
> -
> name: get
> doc: Get / dump OVS vport configuration and state
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2023-08-15 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 20:56 [PATCH net-next 0/3] net: warn about attempts to register negative ifindex Jakub Kicinski
2023-08-14 20:56 ` [PATCH net-next 1/3] " Jakub Kicinski
2023-08-15 7:02 ` Leon Romanovsky
2023-08-14 20:56 ` [PATCH net-next 2/3] netlink: specs: add ovs_vport new command Jakub Kicinski
2023-08-15 8:06 ` Donald Hunter [this message]
2023-08-14 20:56 ` [PATCH net-next 3/3] tools: ynl: add more info to KeyErrors on missing attrs Jakub Kicinski
2023-08-15 8:15 ` Donald Hunter
2023-08-16 2:40 ` [PATCH net-next 0/3] net: warn about attempts to register negative ifindex patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sf8kk9un.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).