netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Hopps <chopps@chopps.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: Leon Romanovsky <leon@kernel.org>,
	Antony Antony <antony@phenome.org>,
	antony.antony@secunet.com,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eyal Birger <eyal.birger@gmail.com>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	devel@linux-ipsec.org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v8] xfrm: Add Direction to the SA in or out
Date: Mon, 15 Apr 2024 07:12:03 -0400	[thread overview]
Message-ID: <m2ttk2j2he.fsf@ja.int.chopps.org> (raw)
In-Reply-To: <Zhz1DmZZCrMq__B_@hog>

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]


Sabrina Dubroca via Devel <devel@linux-ipsec.org> writes:

> 2024-04-14, 13:45:00 +0300, Leon Romanovsky wrote:
>> Right, but what about new iproute2, which eventually will users get
>> after system update and old scripts?
>
> I suspect that new iproute2 will add an option to set the direction
> (otherwise it'd have to guess a value, that's not the goal of xfrm
> support in iproute), and only pass XFRMA_SA_DIR when the user gave
> that extra argument, so nothing will change there either?

Indeed.

I have a set of iproute2 changes for iptfs, and I was going to update those with the "in"/"out" keyword if it hadn't been added by the time I submit them, I would associate the corresponding iptfs attributes with one of those flags.

I hadn't planned on changing any restrictions for existing iproute2 options/flags as doing so might break user scripts etc :)

Thanks,
Chris.

>
> --
> Sabrina


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2024-04-15 11:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09 17:37 [PATCH ipsec-next v8] xfrm: Add Direction to the SA in or out Antony Antony
2024-04-11 10:37 ` [devel-ipsec] " Leon Romanovsky
2024-04-11 11:07   ` Antony Antony
2024-04-11 11:55     ` [devel-ipsec] " Leon Romanovsky
2024-04-11 20:00       ` Sabrina Dubroca
2024-04-14 10:45         ` Leon Romanovsky
2024-04-15  9:36           ` Sabrina Dubroca
2024-04-15 11:12             ` Christian Hopps [this message]
2024-04-15 18:12             ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ttk2j2he.fsf@ja.int.chopps.org \
    --to=chopps@chopps.org \
    --cc=antony.antony@secunet.com \
    --cc=antony@phenome.org \
    --cc=davem@davemloft.net \
    --cc=devel@linux-ipsec.org \
    --cc=edumazet@google.com \
    --cc=eyal.birger@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).