Re: [PATCH v12 net-next 1/5] Documentation: netlink: specs: tc: Add DualPI2 specification

[Donald Hunter <donald.hunter@gmail.com>]

"Chia-Yu Chang (Nokia)" <chia-yu.chang@nokia-bell-labs.com> writes:

>> The syntax is not valid so this doesn't pass the schema check and presumably hasn't been tested. Please validate YNL .yaml additions e.g.
>> 
>> ./tools/net/ynl/pyynl/cli.py \
>>     --spec Documentation/netlink/specs/tc.yaml \
>>     --list-ops
>> 
>> ...
>> jsonschema.exceptions.ValidationError: Additional properties are not allowed ('entries' was unexpected) ...
>> On instance['attribute-sets'][30]['attributes'][14]:
>>     {'name': 'gso_split',
>>      'type': 'flags',
>>      'doc': 'Split aggregated skb or not',
>>      'entries': ['split_gso', 'no_split_gso']}
>> 
>
> Hi Donald,
>
> 	Thanks for the feedback, and I will take actions for below points as well as the corresponding iproute2-net fixes.
> 	One more question is I see "uint" type is not valid during validation - see below (but which was suggested in v11), shall I change it back to u32/u8?
>
> Failed validating 'enum' in schema['properties']['definitions']['items']['properties']['members']['items']['properties']['type']:
>     {'description': "The netlink attribute type. Members of type 'binary' "
>                     "or 'pad'\n"
>                     "must also have the 'len' property set.\n",
>      'enum': ['u8',
>               'u16',
>               'u32',
>               'u64',
>               's8',
>               's16',
>               's32',
>               's64',
>               'string',
>               'binary',
>               'pad']}
>
> On instance['definitions'][42]['members'][12]['type']:
>     'uint'	

The advice from Paolo was a bit misleading. It is correct for netlink
attributes which support variable size scalars, but not for struct
members which must be a fixed size.

So for tc-dualpi2-xstats, the member types must match the struct
tc_dualpi2_xstats types.