From: Donald Hunter <donald.hunter@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
donald.hunter@redhat.com,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net-next v5 11/12] doc/netlink: Add spec for rt link messages
Date: Fri, 25 Aug 2023 10:04:20 +0100 [thread overview]
Message-ID: <m2y1hzebmz.fsf@gmail.com> (raw)
In-Reply-To: <ZOeJXfT2lhVAaOAk@nanopsycho> (Jiri Pirko's message of "Thu, 24 Aug 2023 18:46:21 +0200")
Jiri Pirko <jiri@resnulli.us> writes:
> Thu, Aug 24, 2023 at 01:20:02PM CEST, donald.hunter@gmail.com wrote:
>
> [...]
>
>>+attribute-sets:
>>+ -
>>+ name: link-attrs
>>+ name-prefix: ifla-
>>+ attributes:
>>+ -
>>+ name: address
>>+ type: binary
>>+ display-hint: mac
>>+ value: 1
>>+ -
>>+ name: broadcast
>>+ type: binary
>>+ display-hint: mac
>>+ value: 2
>
> Why do you specify value here? In general, it is not needed if it
> is the prev+1.
I added the values when I generated some of the spec contents from
btftool output and they were helpful for visual lookup when I was
working on the spec.
I can remove them.
>>+ -
>>+ name: ifname
>>+ type: string
>>+ value: 3
>
> [...]
next prev parent reply other threads:[~2023-08-25 9:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 11:19 [PATCH net-next v5 00/12] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 01/12] doc/netlink: Fix typo in genetlink-* schemas Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 02/12] doc/netlink: Add a schema for netlink-raw families Donald Hunter
2023-08-24 21:04 ` Jacob Keller
2023-08-24 11:19 ` [PATCH net-next v5 03/12] doc/netlink: Update genetlink-legacy documentation Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 04/12] doc/netlink: Document the netlink-raw schema extensions Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 05/12] tools/ynl: Add mcast-group schema parsing to ynl Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 06/12] tools/net/ynl: Fix extack parsing with fixed header genlmsg Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 07/12] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-08-24 11:19 ` [PATCH net-next v5 08/12] tools/net/ynl: Implement nlattr array-nest decoding in ynl Donald Hunter
2023-08-24 11:20 ` [PATCH net-next v5 09/12] tools/net/ynl: Add support for create flags Donald Hunter
2023-08-24 11:20 ` [PATCH net-next v5 10/12] doc/netlink: Add spec for rt addr messages Donald Hunter
2023-08-24 11:20 ` [PATCH net-next v5 11/12] doc/netlink: Add spec for rt link messages Donald Hunter
2023-08-24 16:46 ` Jiri Pirko
2023-08-25 9:04 ` Donald Hunter [this message]
2023-08-24 11:20 ` [PATCH net-next v5 12/12] doc/netlink: Add spec for rt route messages Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y1hzebmz.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).