From: Vincent Bernat <vincent@bernat.im>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets
Date: Sat, 11 Nov 2017 13:44:34 +0100 [thread overview]
Message-ID: <m31sl5rnm5.fsf@luffy.cx> (raw)
In-Reply-To: <4044ad2be78d1905117fba5e464ce67b22f48633.1510401530.git.lucien.xin@gmail.com> (Xin Long's message of "Sat, 11 Nov 2017 19:58:50 +0800")
❦ 11 novembre 2017 19:58 +0800, Xin Long <lucien.xin@gmail.com> :
> Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport
> header offset") removed icmp6_code and icmp6_type check before calling
> neigh_reduce when doing neigh proxy.
>
> It means all icmpv6 packets would be blocked by this, not only ns packet.
> In Jianlin's env, even ping6 couldn't work through it.
>
> This patch is to bring the icmp6_code and icmp6_type check back and also
> removed the same check from neigh_reduce().
I am very sorry for not having spotted this bug earlier. I have tested
your fix and I can confirm it works as expected.
> Fixes: f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport header offset")
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Vincent Bernat <vincent@bernat.im>
--
Don't just echo the code with comments - make every comment count.
- The Elements of Programming Style (Kernighan & Plauger)
next prev parent reply other threads:[~2017-11-11 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 11:58 [PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets Xin Long
2017-11-11 12:44 ` Vincent Bernat [this message]
2017-11-14 7:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31sl5rnm5.fsf@luffy.cx \
--to=vincent@bernat.im \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).