From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC Date: Fri, 18 Apr 2008 17:58:48 +0200 Message-ID: References: <20080411221448.22b69ff5.akpm@linux-foundation.org> <20080412115950.1cbb9cfa@core> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Jeff Garzik , , , David Miller To: Alan Cox Return-path: In-Reply-To: (Krzysztof Halasa's message of "Sat\, 12 Apr 2008 22\:19\:28 +0200") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Update: > Yes, I could add another dirty "interface fix" to the HDLC + syncppp > combo (hdlc_ppp), but I don't really see a sense, especially that I > have the new implementation ready and working (my time resources are > currently quite limited and if I have to choose between adding another > glue fix and writing a better PPP replacement I pick the latter). > > > My original post: http://lkml.org/lkml/2008/3/12/277 David doesn't want the new PPP, insisting that I fix existing hdlc_ppp.c + syncppp.c combo instead, and that there are related bugs in drivers using syncppp.c alone (not hdlc_ppp) which I have to fix as well. Unfortunately I'm unable to do that. Even if I could add another workaround to hdlc_ppp to make it work with syncppp.c again, I can't fix the other drivers (if they are indeed broken) because of lack of hardware, and I can't really make significant changes to syncppp.c (to make them available to all drivers) because that could and would break those drivers. Comments? -- Krzysztof Halasa