netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benny Amorsen <benny+usenet@amorsen.dk>
To: Gertjan Hofman <gertjan_hofman@yahoo.com>
Cc: Matt Carlson <mcarlson@broadcom.com>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: VLAN and ARP failure on tg3 drivers
Date: Mon, 26 Oct 2009 09:20:48 +0100	[thread overview]
Message-ID: <m34opmr2fz.fsf@ursa.amorsen.dk> (raw)
In-Reply-To: <477963.52849.qm@web32605.mail.mud.yahoo.com> (Gertjan Hofman's message of "Sun, 25 Oct 2009 21:30:09 -0700 (PDT)")

Gertjan Hofman <gertjan_hofman@yahoo.com> writes:

> Dear Matt, Eric, Benny,
>
> Sorry about the slow response to your fast replies. I think Benny is
> correct, the 'problem' lies in the fact that we were using a VLAN ID
> of 0, without knowing its special significance. User error.
>
> I tested it with other VLAN id's (>0) and it appears to work fine. We
> are not entirely sure we understand  why it used to work with VLAN ID
> 0 on the Broadcom chips and still does with a number of different
> cards (with >2.6.27 kernels).  What is the 'correct' behaviour for
> this incorrect usage ?

VLAN 0 isn't incorrect, it's just surprising. When you send a packet
tagged with VLAN 0, it means that the packet should be interpreted as
being the same VLAN as a completely untagged packet.

So in theory, if both ends are using VLAN 0 and you aren't using eth0
for anything, traffic should flow, at least if both ends are on the same
kernel version. Feel free to debug why that isn't the case for you, of
course...


/Benny


  reply	other threads:[~2009-10-26  8:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26  4:30 VLAN and ARP failure on tg3 drivers Gertjan Hofman
2009-10-26  8:20 ` Benny Amorsen [this message]
2009-10-26  8:54   ` Eric Dumazet
2009-10-26 16:13     ` [PATCH] vlan: allow VLAN ID 0 to be used Eric Dumazet
2009-10-27  0:32       ` David Miller
2009-10-27  1:34         ` Eric Dumazet
2009-10-27  1:41           ` David Miller
2009-10-27  9:52       ` Benny Amorsen
2009-10-27 10:02         ` Eric Dumazet
2009-10-28 16:13           ` Patrick McHardy
  -- strict thread matches above, loose matches on Subject: below --
2009-10-23  4:52 VLAN and ARP failure on tg3 drivers Gertjan Hofman
2009-10-23  5:23 ` Eric Dumazet
2009-10-23  9:12 ` Benny Amorsen
2009-10-23 21:35 ` Matt Carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34opmr2fz.fsf@ursa.amorsen.dk \
    --to=benny+usenet@amorsen.dk \
    --cc=eric.dumazet@gmail.com \
    --cc=gertjan_hofman@yahoo.com \
    --cc=mcarlson@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).