* [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver.
@ 2009-09-04 17:50 Krzysztof Halasa
2009-09-05 6:07 ` David Miller
2009-09-05 10:54 ` Krzysztof Halasa
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Halasa @ 2009-09-04 17:50 UTC (permalink / raw)
To: David Miller; +Cc: netdev
PCI200SYN has its own PCI subsystem device ID for 3+ years, now it's
time to remove the generic PLX905[02] ID from the driver. Anyone with
old EEPROM data will have to run the upgrade.
Having the generic PLX905[02] (PCI-local bus bridge) ID is harmful
as the driver tries to handle other devices based on these bridges.
--
Krzysztof Halasa
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -360,15 +360,6 @@ static int __devinit pci200_pci_init_one(struct pci_dev *pdev,
" %u RX packets rings\n", ramsize / 1024, ramphys,
pdev->irq, card->tx_ring_buffers, card->rx_ring_buffers);
- if (pdev->subsystem_device == PCI_DEVICE_ID_PLX_9050) {
- printk(KERN_ERR "Detected PCI200SYN card with old "
- "configuration data.\n");
- printk(KERN_ERR "See <http://www.kernel.org/pub/"
- "linux/utils/net/hdlc/pci200syn/> for update.\n");
- printk(KERN_ERR "The card will stop working with"
- " future versions of Linux if not updated.\n");
- }
-
if (card->tx_ring_buffers < 1) {
printk(KERN_ERR "pci200syn: RAM test failed\n");
pci200_pci_remove_one(pdev);
@@ -427,8 +418,6 @@ static int __devinit pci200_pci_init_one(struct pci_dev *pdev,
static struct pci_device_id pci200_pci_tbl[] __devinitdata = {
{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_PLX,
- PCI_DEVICE_ID_PLX_9050, 0, 0, 0 },
- { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_PLX,
PCI_DEVICE_ID_PLX_PCI200SYN, 0, 0, 0 },
{ 0, }
};
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver.
2009-09-04 17:50 [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver Krzysztof Halasa
@ 2009-09-05 6:07 ` David Miller
2009-09-05 10:52 ` Krzysztof Halasa
2009-09-05 10:54 ` Krzysztof Halasa
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2009-09-05 6:07 UTC (permalink / raw)
To: khc; +Cc: netdev
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Fri, 04 Sep 2009 19:50:16 +0200
> PCI200SYN has its own PCI subsystem device ID for 3+ years, now it's
> time to remove the generic PLX905[02] ID from the driver. Anyone with
> old EEPROM data will have to run the upgrade.
>
> Having the generic PLX905[02] (PCI-local bus bridge) ID is harmful
> as the driver tries to handle other devices based on these bridges.
Please provide a proper signoff with all patches.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver.
2009-09-04 17:50 [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver Krzysztof Halasa
2009-09-05 6:07 ` David Miller
@ 2009-09-05 10:54 ` Krzysztof Halasa
2009-09-07 8:58 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Halasa @ 2009-09-05 10:54 UTC (permalink / raw)
To: David Miller; +Cc: netdev
PCI200SYN has its own PCI subsystem device ID for 3+ years, now it's
time to remove the generic PLX905[02] ID from the driver. Anyone with
old EEPROM data will have to run the upgrade.
Having the generic PLX905[02] (PCI-local bus bridge) ID is harmful
as the driver tries to handle other devices based on these bridges.
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -360,15 +360,6 @@ static int __devinit pci200_pci_init_one(struct pci_dev *pdev,
" %u RX packets rings\n", ramsize / 1024, ramphys,
pdev->irq, card->tx_ring_buffers, card->rx_ring_buffers);
- if (pdev->subsystem_device == PCI_DEVICE_ID_PLX_9050) {
- printk(KERN_ERR "Detected PCI200SYN card with old "
- "configuration data.\n");
- printk(KERN_ERR "See <http://www.kernel.org/pub/"
- "linux/utils/net/hdlc/pci200syn/> for update.\n");
- printk(KERN_ERR "The card will stop working with"
- " future versions of Linux if not updated.\n");
- }
-
if (card->tx_ring_buffers < 1) {
printk(KERN_ERR "pci200syn: RAM test failed\n");
pci200_pci_remove_one(pdev);
@@ -427,8 +418,6 @@ static int __devinit pci200_pci_init_one(struct pci_dev *pdev,
static struct pci_device_id pci200_pci_tbl[] __devinitdata = {
{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_PLX,
- PCI_DEVICE_ID_PLX_9050, 0, 0, 0 },
- { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_PLX,
PCI_DEVICE_ID_PLX_PCI200SYN, 0, 0, 0 },
{ 0, }
};
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver.
2009-09-05 10:54 ` Krzysztof Halasa
@ 2009-09-07 8:58 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2009-09-07 8:58 UTC (permalink / raw)
To: khc; +Cc: netdev
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Sat, 05 Sep 2009 12:54:30 +0200
> PCI200SYN has its own PCI subsystem device ID for 3+ years, now it's
> time to remove the generic PLX905[02] ID from the driver. Anyone with
> old EEPROM data will have to run the upgrade.
>
> Having the generic PLX905[02] (PCI-local bus bridge) ID is harmful
> as the driver tries to handle other devices based on these bridges.
>
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Applied to net-next-2.6, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-07 8:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-04 17:50 [PATCH] WAN: remove deprecated PCI_DEVICE_ID from PCI200SYN driver Krzysztof Halasa
2009-09-05 6:07 ` David Miller
2009-09-05 10:52 ` Krzysztof Halasa
2009-09-05 10:54 ` Krzysztof Halasa
2009-09-07 8:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).