From: Benny Amorsen <benny+usenet@amorsen.dk>
To: Jarod Neuner <j.neuner@networkharbor.com>
Cc: Patrick McHardy <kaber@trash.net>,
David Miller <davem@davemloft.net>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: IGMP sent to Foreign VLAN
Date: Sat, 11 Oct 2008 00:45:36 +0200 [thread overview]
Message-ID: <m363o0m5m7.fsf@ursa.amorsen.dk> (raw)
In-Reply-To: <1223508896.24688.95.camel@deepthought.nh.local> (Jarod Neuner's message of "Wed\, 8 Oct 2008 18\:34\:56 -0500")
Jarod Neuner <j.neuner@networkharbor.com> writes:
> My original thought was to do something like this in net/core/dev.c
> using a method similar to handle_bridge or handle_macvlen. So, if the
> packet doesn't get handled by the ptype_base list and IFF_ALLVLAN is
> set, then strip the header and let the packet through. The sticky point
> would be whether or not this policy should be enabled by default, as it
> seems to be in other network stacks.
So if I tcpdump on the base device, IFF_ALLVLAN gets set and packets
from unknown VLAN's suddenly lose their VLAN headers? That's a
security problem.
/Benny
prev parent reply other threads:[~2008-10-10 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 19:51 IGMP sent to Foreign VLAN Jarod Neuner
2008-10-07 23:07 ` David Miller
2008-10-07 23:53 ` Patrick McHardy
2008-10-08 23:34 ` Jarod Neuner
2008-10-09 12:31 ` Patrick McHardy
2008-10-09 16:18 ` Jarod Neuner
2008-10-10 16:28 ` Patrick McHardy
2008-10-10 22:45 ` Benny Amorsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m363o0m5m7.fsf@ursa.amorsen.dk \
--to=benny+usenet@amorsen.dk \
--cc=davem@davemloft.net \
--cc=j.neuner@networkharbor.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).