From: Krzysztof Halasa <khc@pm.waw.pl>
To: Adrian Bunk <bunk@kernel.org>
Cc: netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: WAN: Remove dead code from wanmain.c, CONFIG_WANPIPE_MULTPPP doesn't exist
Date: Wed, 02 Jul 2008 22:21:34 +0200 [thread overview]
Message-ID: <m363ro3ult.fsf@maximus.localdomain> (raw)
In-Reply-To: <20080702201754.GA2145@cs181140183.pp.htv.fi> (Adrian Bunk's message of "Wed\, 2 Jul 2008 23\:17\:55 +0300")
Adrian Bunk <bunk@kernel.org> writes:
>> -#ifdef CONFIG_WANPIPE_MULTPPP
>> - pppdev = kzalloc(sizeof(struct ppp_device), GFP_KERNEL);
>> - err = -ENOBUFS;
>> - if (pppdev == NULL)
>> - goto out;
>> - pppdev->dev = kzalloc(sizeof(struct net_device), GFP_KERNEL);
>> - if (pppdev->dev == NULL) {
>> - kfree(pppdev);
>> - err = -ENOBUFS;
>> - goto out;
>> - }
>> - err = wandev->new_if(wandev, (struct net_device *)pppdev, cnf);
>> - dev = pppdev->dev;
>> -#else
>> printk(KERN_INFO "%s: Wanpipe Mulit-Port PPP support has not been compiled in!\n",
>> wandev->name);
>
> The printk() also needs some updating.
Agreed.
--
Krzysztof Halasa
next prev parent reply other threads:[~2008-07-02 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 19:12 WAN: Remove dead code from wanmain.c, CONFIG_WANPIPE_MULTPPP doesn't exist Krzysztof Halasa
2008-07-02 20:17 ` Adrian Bunk
2008-07-02 20:21 ` Krzysztof Halasa [this message]
2008-07-09 14:44 ` Lennart Sorensen
2008-07-09 20:43 ` Krzysztof Halasa
2008-07-09 20:45 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m363ro3ult.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox