From: Vincent Bernat <vincent@bernat.im>
To: David Miller <davem@davemloft.net>
Cc: dsa@cumulusnetworks.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable
Date: Mon, 19 Sep 2016 22:27:32 +0200 [thread overview]
Message-ID: <m3a8f3k53f.fsf@neo.luffy.cx> (raw)
In-Reply-To: <20160919.005857.553516799273302087.davem@davemloft.net> (David Miller's message of "Mon, 19 Sep 2016 00:58:57 -0400 (EDT)")
❦ 19 septembre 2016 06:58 CEST, David Miller <davem@davemloft.net> :
>> @@ -1808,6 +1808,30 @@ static struct rt6_info *ip6_nh_lookup_table(struct net *net,
>> return rt;
>> }
>>
>> +static int ip6_nh_valid(struct rt6_info *grt,
>> + struct net_device **dev, struct inet6_dev **idev) {
>> + int ret = 0;
>
> First, this is not formatted properly. The openning brace should start
> on a new line.
>
> Second, please use "bool", "true", and "false" for the return value.
Noted for the next time. However, the v3 version of the patch doesn't
have the function anymore.
--
Avoid temporary variables.
- The Elements of Programming Style (Kernighan & Plauger)
prev parent reply other threads:[~2016-09-19 20:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 12:55 [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable Vincent Bernat
2016-09-16 18:36 ` David Ahern
2016-09-16 19:15 ` Vincent Bernat
2016-09-16 19:38 ` David Ahern
2016-09-16 20:33 ` [v2] " Vincent Bernat
2016-09-18 15:12 ` David Ahern
2016-09-18 15:46 ` [v3] " Vincent Bernat
2016-09-18 15:47 ` David Ahern
2016-09-20 7:29 ` David Miller
2016-09-19 4:58 ` [PATCH] " David Miller
2016-09-19 20:27 ` Vincent Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a8f3k53f.fsf@neo.luffy.cx \
--to=vincent@bernat.im \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).