From: Benny Amorsen <benny+usenet@amorsen.dk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: unlisted-recipients:; (no To-header on input) Gertjan Hofman
<gertjan_hofman@yahoo.com>, Matt Carlson <mcarlson@broadcom.com>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] vlan: allow VLAN ID 0 to be used
Date: Tue, 27 Oct 2009 10:52:41 +0100 [thread overview]
Message-ID: <m3aazdb1ue.fsf@ursa.amorsen.dk> (raw)
In-Reply-To: <4AE5CAC6.4000604@gmail.com> (Eric Dumazet's message of "Mon, 26 Oct 2009 17:13:58 +0100")
Eric Dumazet <eric.dumazet@gmail.com> writes:
> Here is the patch I cooked that permitted VLAN 0 to be used with tg3
> (and other HW accelerated vlan nics I suppose)
>
> [PATCH] vlan: allow VLAN ID 0 to be used
>
> We currently use a 16 bit field (vlan_tci) to store VLAN ID on a skb.
>
> 0 value is used a special value, meaning VLAN ID not set.
> This forbids use of VLAN ID 0
Are you sure you actually want to do this?
VLAN 0 IS special. Frames received on VLAN 0 should be treated just as
if they had no VLAN tag at all, except that they have an 802.1p value.
Sending frames with VLAN 0 should have something to do with whether
the sender wants to use 802.1p, which doesn't really have much to do
with VLAN's at all...
It would be nice if the unsuspecting user was at least warned that their
use of VLAN 0 is non-standard and may cause surprising results like
leakage into the "native" VLAN. That could be done in /sbin/ip or
/sbin/vconfig, of course.
/Benny
next prev parent reply other threads:[~2009-10-27 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 4:30 VLAN and ARP failure on tg3 drivers Gertjan Hofman
2009-10-26 8:20 ` Benny Amorsen
2009-10-26 8:54 ` Eric Dumazet
2009-10-26 16:13 ` [PATCH] vlan: allow VLAN ID 0 to be used Eric Dumazet
2009-10-27 0:32 ` David Miller
2009-10-27 1:34 ` Eric Dumazet
2009-10-27 1:41 ` David Miller
2009-10-27 9:52 ` Benny Amorsen [this message]
2009-10-27 10:02 ` Eric Dumazet
2009-10-28 16:13 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aazdb1ue.fsf@ursa.amorsen.dk \
--to=benny+usenet@amorsen.dk \
--cc=eric.dumazet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).