From: Krzysztof Halasa <khc@pm.waw.pl>
To: David Miller <davem@davemloft.net>
Cc: risto.suominen@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 002/002] de2104x: support for systems lacking cache coherence
Date: Tue, 10 Feb 2009 02:45:46 +0100 [thread overview]
Message-ID: <m3ab8v3vzp.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20090209.145156.172588416.davem@davemloft.net> (David Miller's message of "Mon\, 09 Feb 2009 14\:51\:56 -0800 \(PST\)")
David Miller <davem@davemloft.net> writes:
> The issue are descriptors that are _written_ by both the cpu
> and the device. That is the problematic case here.
Do you mean both CPU and 21040 write to the same descriptor at (nearly)
the same time? Is it TX, RX or both?
I wonder, how would the patch help it?
The patch seems to align the descriptors on cache line boundary. That
IMHO means the corruption is caused by the 21040 writing to e.g. desc
#0, CPU writing to desc #1, which causes the cache line write bringing
the old desc #0 back.
Is it possible to use uncached memory for coherent allocations (with no
write side effects) on this machine?
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-02-10 1:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46e1c7760902071330i5362fe4fvd99fc7075fc666d3@mail.gmail.com>
2009-02-09 7:27 ` Fwd: [PATCH 002/002] de2104x: support for systems lacking cache coherence Risto Suominen
2009-02-09 7:45 ` David Miller
2009-02-09 8:22 ` Risto Suominen
2009-02-09 8:29 ` David Miller
2009-02-09 8:35 ` Risto Suominen
2009-02-09 16:58 ` Krzysztof Halasa
2009-02-09 19:22 ` Risto Suominen
2009-02-09 22:51 ` David Miller
2009-02-10 1:45 ` Krzysztof Halasa [this message]
2009-02-10 1:50 ` David Miller
2009-02-10 23:21 ` David Miller
2009-02-11 12:18 ` Risto Suominen
2009-02-11 12:31 ` Risto Suominen
2009-02-11 21:39 ` David Miller
2009-02-13 3:42 ` Benjamin Herrenschmidt
2009-02-10 1:01 ` Andrew Morton
2009-02-10 1:07 ` David Miller
2009-02-10 7:16 ` Risto Suominen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ab8v3vzp.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=risto.suominen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox