From: Krzysztof Halasa <khc@pm.waw.pl>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Jonas Gorski <jogo@openwrt.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@arm.linux.org.uk>,
"Imre Kaloz" <kaloz@openwrt.org>
Subject: Re: [PATCH 1/2] arm: ixp4xx: set cohorent_dma_mask for ethernet platform devices
Date: Mon, 22 Jul 2013 16:49:27 +0200 [thread overview]
Message-ID: <m3bo5uabuw.fsf@intrepid.localdomain> (raw)
In-Reply-To: <1374424823.2804.25.camel@deadeye.wl.decadent.org.uk> (Ben Hutchings's message of "Sun, 21 Jul 2013 17:40:23 +0100")
Ben Hutchings <bhutchings@solarflare.com> writes:
> I think the problem is that the platform device and the platform data
> have not been properly separated. The machine-specific setup functions
> should be passing the eth_plat_info and MAC ID into a common ixp4xx
> function which would then create the platform device with the correct
> DMA mask etc.
That's also my idea. Will look at this.
--
Krzysztof Halasa
next prev parent reply other threads:[~2013-07-22 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 10:15 [PATCH 0/2] net: fix ixp4xx_eth Jonas Gorski
2013-07-20 10:15 ` [PATCH 1/2] arm: ixp4xx: set cohorent_dma_mask for ethernet platform devices Jonas Gorski
2013-07-21 14:45 ` Krzysztof Halasa
2013-07-21 16:40 ` Ben Hutchings
2013-07-22 14:49 ` Krzysztof Halasa [this message]
2013-07-20 10:15 ` [PATCH 2/2] net: ixp4xx_eth: use parent device for dma allocations Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bo5uabuw.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jogo@openwrt.org \
--cc=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).