From: Krzysztof Halasa <khc@pm.waw.pl>
To: Andrew Hendry <andrew.hendry@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 6/6] X25: Use identifiers for hdlc x25 device to x25 interface
Date: Sun, 18 Apr 2010 14:39:16 +0200 [thread overview]
Message-ID: <m3eiid540b.fsf@intrepid.localdomain> (raw)
In-Reply-To: <1271584429.6280.435.camel@ibex> (Andrew Hendry's message of "Sun, 18 Apr 2010 19:53:49 +1000")
Andrew Hendry <andrew.hendry@gmail.com> writes:
> Change magic numbers to identifiers for X25 interface.
Looks good to me, ack.
> Note, x25_connect_disconnect 'reason' appears unimplemented?
To be honest, I don't know this stuff at all. I've added it years ago to
the point some x25 telnet (or something like that) connected to some
server, then I had a successful confirmation from somebody. Personally
I don't even enable X.25 in my tests. I don't know if someone is still
using this code.
--
Krzysztof Halasa
prev parent reply other threads:[~2010-04-18 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 9:53 [PATCH 6/6] X25: Use identifiers for hdlc x25 device to x25 interface Andrew Hendry
2010-04-18 12:39 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eiid540b.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=andrew.hendry@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).