netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: <netdev@oss.sgi.com>
Subject: [PATCH] 2.6.x Tulip oops while doing eject/rmmod on live interface
Date: Mon, 26 Apr 2004 03:30:41 +0200	[thread overview]
Message-ID: <m3hdv7o79a.fsf@defiant.pm.waw.pl> (raw)

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

Hi,

The attached patch fixes an "oops" in tulip driver when a live interface
is deactivated (i.e. PC Card ejected or module unloaded) without being
brought down first.

Please apply to Linux 2.6. Thanks.
-- 
Krzysztof Halasa, B*FH

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tulip-rmmod.patch --]
[-- Type: text/x-patch, Size: 497 bytes --]

--- linux/drivers/net/tulip/tulip_core.c	19 Apr 2004 17:04:06 -0000
+++ linux.orig/drivers/net/tulip/tulip_core.c	26 Apr 2004 01:08:31 -0000
@@ -1761,11 +1761,11 @@
 		return;
 
 	tp = netdev_priv(dev);
+	unregister_netdev(dev);
 	pci_free_consistent (pdev,
 			     sizeof (struct tulip_rx_desc) * RX_RING_SIZE +
 			     sizeof (struct tulip_tx_desc) * TX_RING_SIZE,
 			     tp->rx_ring, tp->rx_ring_dma);
-	unregister_netdev (dev);
 	if (tp->mtable)
 		kfree (tp->mtable);
 #ifndef USE_IO_OPS

             reply	other threads:[~2004-04-26  1:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-26  1:30 Krzysztof Halasa [this message]
2004-04-26  1:40 ` [PATCH] 2.6.x Tulip oops while doing eject/rmmod on live interface Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hdv7o79a.fsf@defiant.pm.waw.pl \
    --to=khc@pm.waw.pl \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).