From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement Date: Tue, 23 Dec 2008 18:36:22 +0100 Message-ID: References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191507.11807.50794.stgit@vmbox.hanneseder.net> <1230053186.1447.9.camel@brick> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , =?utf-8?B?SMOla29uIEzDuHZkYWw=?= , Hannes Eder , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Harvey Harrison Return-path: Received: from khc.piap.pl ([195.187.100.11]:35942 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbYLWRgY (ORCPT ); Tue, 23 Dec 2008 12:36:24 -0500 In-Reply-To: <1230053186.1447.9.camel@brick> (Harvey Harrison's message of "Tue\, 23 Dec 2008 09\:26\:26 -0800") Sender: netdev-owner@vger.kernel.org List-ID: Harvey Harrison writes: >> There are many ways to make the code more merge friendly at a cost of >> readability. Hope we don't go this way. > > Linus himself added that particular warning to sparse...may want to check > with him the reason for it. Once again, this is a personal thing, and a harmless one. Sometimes I think using this sparse thing does more harm than good. Not that the tool itself is bad - I find it really useful, many sparse warnings actually did cause code improvement. It's like with knives, there are good uses and a bit less good ones. -- Krzysztof Halasa