From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" Date: Mon, 07 May 2007 22:54:53 +0200 Message-ID: References: <463F27CE.2040008@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff Garzik , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk To: Roman Zippel Return-path: Received: from khc.piap.pl ([195.187.100.11]:41328 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966860AbXEGUyz (ORCPT ); Mon, 7 May 2007 16:54:55 -0400 In-Reply-To: (Roman Zippel's message of "Mon, 7 May 2007 19:07:43 +0200 (CEST)") Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Roman Zippel writes: > Normal dependencies, you basically have to manually make sure they are > correct (and it seems with your patch they aren't). Again, _please_ (with > sugar on top) don't use select unless you have a good reason for it. You perhaps mean WAN dependency, don't you? I was under impression that the "menu" patches have already been merged so the WAN dependency would be automatic. Anything other than that? Sure, I can see now. I can only say, in my defense, that I was (and still am) very tired. I'm going to get some coffee. There is still a very good reason for the select. CONFIG_HDLC _is_ a simple library, though probably not the most simple one. I really feel it's an improvement. Attaching two patches, hopefully the double check is enough. -- Krzysztof Halasa