From: Krzysztof Halasa <khc@pm.waw.pl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM
Date: Sun, 03 Sep 2006 14:43:20 +0200 [thread overview]
Message-ID: <m3k64lm87r.fsf@defiant.localdomain> (raw)
In-Reply-To: <20060903111507.GA12580@gondor.apana.org.au> (Herbert Xu's message of "Sun, 3 Sep 2006 21:15:07 +1000")
Herbert Xu <herbert@gondor.apana.org.au> writes:
> [NET]: Drop tx lock in dev_watchdog_up
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -238,9 +238,7 @@ void __netdev_watchdog_up(struct net_dev
>
> static void dev_watchdog_up(struct net_device *dev)
> {
> - netif_tx_lock_bh(dev);
> __netdev_watchdog_up(dev);
> - netif_tx_unlock_bh(dev);
> }
>
> static void dev_watchdog_down(struct net_device *dev)
Many thanks for looking into this. The lockdep warning is gone now.
--
Krzysztof Halasa
--
VGER BF report: H 3.43998e-11
next prev parent reply other threads:[~2006-09-03 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-02 20:39 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM Krzysztof Halasa
2006-09-02 21:48 ` Francois Romieu
2006-09-02 22:59 ` Krzysztof Halasa
2006-09-03 11:15 ` Herbert Xu
2006-09-03 12:43 ` Krzysztof Halasa [this message]
2006-09-03 19:26 ` Larry Finger
2006-09-04 8:44 ` Alexey Kuznetsov
2006-09-04 8:48 ` Herbert Xu
2006-09-18 7:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k64lm87r.fsf@defiant.localdomain \
--to=khc@pm.waw.pl \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox