Re: [PATCH] Re: WAN: new PPP code for generic HDLC

Krzysztof Halasa
2008-03-12T20:10:36Z

Jan Engelhardt <jengelh@computergmbh.de> writes:

>>+ /* LCP only */
>>+ if (pid == PID_LCP)
>>+ switch (cp->code) {
>>+ case LCP_PROTO_REJ:
>>+ pid = ntohs(*(__be16*)skb->data);
>
> What if skb->data happens to be unaligned (can that even happen?)

It can't if the hdlc header is 32-bit aligned... however, I can now
see the above is buggy, skb->data doesn't point to the protocol
field. Unused code paths :-(

> -static const char *code_names[CP_CODES] = {"0", "ConfReq", "ConfAck",
> +static const char *const code_names[] = {"0", "ConfReq", "ConfAck",
> "ConfNak", "ConfRej", "TermReq",
> "TermAck", "CodeRej", "ProtoRej",
> "EchoReq", "EchoReply", "Discard"};

The explicit sizes are there as a prevention.
Thanks.
--
Krzysztof Halasa