Re: [PATCH] Re: WAN: new PPP code for generic HDLC

Stephen Hemminger
2008-03-12T18:52:22Z

> +struct hdlc_header {
> + u8 address;
> + u8 control;
> + __be16 protocol;
> +} __attribute__ ((packed));
> +
> +struct cp_header {
> + u8 code;
> + u8 id;
> + __be16 len;
> +} __attribute__ ((packed));
> +

If I remember correctly, the packed is unnecessary for structures like this
and causes GCC to generate worse code.