From: Jes Sorensen <jes@trained-monkey.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>,
jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.5.70] acenic -- update to use alloc_etherdev
Date: 12 Jun 2003 13:05:11 -0400 [thread overview]
Message-ID: <m3n0gnxm48.fsf@trained-monkey.org> (raw)
In-Reply-To: <3EE81263.4040205@osdl.org>
>>>>> "Stephen" == Stephen Hemminger <shemminger@osdl.org> writes:
Stephen> The funny thing is this alloc_etherdev patch did not change
Stephen> the compatiablity one bit. Just for grins, took the 2.5
Stephen> driver back into the 2.4.18 and it doesn't build. The
Stephen> problem is it doesn't know what irqreturn_t is. The enclosed
Stephen> cribbed from atm/he.c fixes that, but it still redefines
Stephen> local_irq_save etc.
Hi Stephen,
I went back and looked at the comment in 2.4 for when alloc_etherdev
was introduced, but clearly I got the mapping of this to the 2.4.x
release dates wrong. That was my bad.
As for local_irq_save() those patches will still be needed if they are
not present in 2.4.17 (I think this is probably a reasonable cut-off
release), if it's in 2.4.17+ I'll agree we can pull it.
But the irqreturn_t compat stuff still needs to go in since it's
clearly not going to be present in 2.4.18 etc.
Cheers,
Jes
prev parent reply other threads:[~2003-06-12 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 21:42 [PATCH 2.5.70] acenic -- update to use alloc_etherdev Stephen Hemminger
2003-06-11 22:21 ` Jes Sorensen
2003-06-12 4:04 ` David S. Miller
2003-06-12 5:44 ` Stephen Hemminger
2003-06-12 17:01 ` Jes Sorensen
[not found] ` <3EE81263.4040205@osdl.org>
2003-06-12 5:43 ` David S. Miller
2003-06-12 17:05 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3n0gnxm48.fsf@trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).