netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: <netdev@vger.kernel.org>
Subject: Re: [RFC] IXP4xx: Add PHYLIB MII ioctl to the Ethernet driver.
Date: Sun, 21 Dec 2008 02:15:44 +0100	[thread overview]
Message-ID: <m3ocz6ba67.fsf@maximus.localdomain> (raw)
In-Reply-To: <m3vdtebadt.fsf@maximus.localdomain> (Krzysztof Halasa's message of "Sun\, 21 Dec 2008 02\:11\:10 +0100")

Few patches I'm posting for review only.

Not for operational use.

IXP4xx: Add PHYLIB MII ioctl to the Ethernet driver.
    
--- a/drivers/net/arm/ixp4xx_eth.c
+++ b/drivers/net/arm/ixp4xx_eth.c
@@ -789,9 +789,11 @@ static void eth_set_mcast_list(struct net_device *dev)
 
 static int eth_ioctl(struct net_device *dev, struct ifreq *req, int cmd)
 {
+	struct port *port = netdev_priv(dev);
+
 	if (!netif_running(dev))
 		return -EINVAL;
-	return -EINVAL;
+	return phy_mii_ioctl(port->phydev, if_mii(req), cmd);
 }
 
 

-- 
Krzysztof Halasa

  parent reply	other threads:[~2008-12-21  1:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-21  1:11 [RFC] IXP4xx: Silence section mismatch warning in Ethernet driver Krzysztof Halasa
2008-12-21  1:12 ` [RFC] IXP4xx: Make the Ethernet driver use built-in netdev stats Krzysztof Halasa
2008-12-21  1:14 ` [RFC] IXP4xx: Add PHYLIB support to Ethernet driver Krzysztof Halasa
2008-12-21  1:15 ` Krzysztof Halasa [this message]
2008-12-21  1:16 ` [RFC] IXP4xx: Add ethtool " Krzysztof Halasa
2008-12-21  1:28 ` [RFC] WAN: Add IXP4xx HSS HDLC driver Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ocz6ba67.fsf@maximus.localdomain \
    --to=khc@pm.waw.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).