From: Krzysztof Halasa <khc@pm.waw.pl>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
PC300 Maintainer <pc300@cyclades.com>
Subject: Generic HDLC update
Date: Tue, 26 Sep 2006 22:42:34 +0200 [thread overview]
Message-ID: <m3odt21hs5.fsf@defiant.localdomain> (raw)
Hi,
Jeff,
in this thread I'm posting two patches:
- 1/2: modularizes generic HDLC code - WAN protocols (FR, Cisco HDLC
etc.) can now be separate modules. We can now have multiple module
versions for a protocol (something like syncppp-based PPP or based
on generic PPP). Also we don't have to load things like syncppp or
lapb if we don't need it.
"Core" generic HDLC code doesn't now know anything about the
WAN protocols - all protocol-related information has been moved from
hdlc.h to the protocol drivers.
- 2/2: while both user-space and low-level driver interfaces are not
changed by the first patch, it has to change data structures
internal to the generic HDLC. Unfortunately, there is one particular
driver - pc300 - abusing those internal structures. There are few
ways to fix this driver but it's not trivial. PC300 maintainer has
been notified about the problem and possible solutions, and has
been sent a copy of the modularizing patch two+ months ago.
This patch removes accesses to the HDLC-internal data structures
from pc300 driver, thus enabling it to compile but breaking part
of its functionality.
Please apply both patches to Linux 2.6.
Thanks.
--
Krzysztof Halasa
next reply other threads:[~2006-09-26 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 20:42 Krzysztof Halasa [this message]
2006-09-26 21:18 ` [PATCH 1/2] Modularize generic HDLC Krzysztof Halasa
2006-09-26 21:23 ` [PATCH 1/2] Modularize generic HDLC - now signed-off Krzysztof Halasa
2006-09-26 21:40 ` Jeff Garzik
2006-09-26 21:48 ` Krzysztof Halasa
2006-09-26 21:24 ` [PATCH 2/2] Make PC300 WAN driver compile again Krzysztof Halasa
2006-09-26 21:35 ` Generic HDLC update Krzysztof Halasa
2006-09-26 21:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3odt21hs5.fsf@defiant.localdomain \
--to=khc@pm.waw.pl \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pc300@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).