From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC Date: Sat, 12 Apr 2008 10:10:40 +0200 Message-ID: References: <20080411221448.22b69ff5.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff Garzik , , To: Andrew Morton Return-path: Received: from khc.piap.pl ([195.187.100.11]:55103 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755415AbYDLIKu (ORCPT ); Sat, 12 Apr 2008 04:10:50 -0400 In-Reply-To: <20080411221448.22b69ff5.akpm@linux-foundation.org> (Andrew Morton's message of "Fri\, 11 Apr 2008 22\:14\:48 -0700") Sender: netdev-owner@vger.kernel.org List-ID: Andrew Morton writes: > It never hurts to resend. It was 6000 patches ago and my mind is a blank. Sure, here is it. Some description, well: PPP support in generic HDLC in Linux 2.6.25 is broken and will cause a kernel panic when a device configured in PPP mode is activated. It will be replaced by new PPP implementation after Linux 2.6.25 is released. This affects only PPP support in generic HDLC (mostly Hitachi SCA and SCA-II based drivers, wanxl, and few others). Standalone syncppp and async PPP support are not affected. Untested :-) Signed-off-by: Krzysztof Halasa --- a/drivers/net/wan/Kconfig +++ b/drivers/net/wan/Kconfig @@ -150,9 +150,13 @@ config HDLC_FR config HDLC_PPP tristate "Synchronous Point-to-Point Protocol (PPP) support" - depends on HDLC + depends on HDLC && BROKEN help Generic HDLC driver supporting PPP over WAN connections. + This module is currently broken and will cause a kernel panic + when a device configured in PPP mode is activated. + + It will be replaced by new PPP implementation in Linux 2.6.26. If unsure, say N.