From: Vincent Bernat <vincent@bernat.im>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next] ipaddress: fix label matching
Date: Sat, 14 Jul 2018 20:58:46 +0200 [thread overview]
Message-ID: <m3r2k5skyh.fsf@luffy.cx> (raw)
In-Reply-To: <0b8902b1-fad1-55ef-acfc-088edb4569c6@gmail.com> (Serhey Popovych's message of "Sat, 14 Jul 2018 21:54:07 +0300")
❦ 14 juillet 2018 21:54 +0300, Serhey Popovych <serhe.popovych@gmail.com> :
> We should leave only filter.label check and return 0:
>
> if (filter.label)
> return 0;
>
> This will ensure we exit from print_linkinfo() earlier, skip
> print_link_stats() and push final filtering by label to
> print_selected_addrinfo() and print_addrinfo().
>
> And finally: this is regression and should be against iproute2, not -next.
As you did the analysis, I let you do the patch.
--
Watch out for off-by-one errors.
- The Elements of Programming Style (Kernighan & Plauger)
prev parent reply other threads:[~2018-07-14 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 11:36 [PATCH iproute2-next] ipaddress: fix label matching Vincent Bernat
2018-07-11 20:03 ` Stephen Hemminger
2018-07-11 20:26 ` Vincent Bernat
2018-07-12 1:01 ` David Ahern
2018-07-12 5:08 ` Vincent Bernat
2018-07-14 8:27 ` Serhey Popovych
2018-07-14 18:54 ` Serhey Popovych
2018-07-14 18:58 ` Vincent Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r2k5skyh.fsf@luffy.cx \
--to=vincent@bernat.im \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).