From: Krzysztof Halasa <khc@pm.waw.pl>
To: Greg KH <gregkh@suse.de>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Tilman Schmidt <tilman@imap.cc>,
Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
isdn4linux@listserv.isdn4linux.de
Subject: Re: Can we remove pci_find_device() yet?
Date: Wed, 13 Jan 2010 16:09:11 +0100 [thread overview]
Message-ID: <m3r5pu6nzc.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20100112211801.GA27999@suse.de> (Greg KH's message of "Tue, 12 Jan 2010 13:18:01 -0800")
Greg KH <gregkh@suse.de> writes:
>> One of our older controllers had a similar design error in that the two
>> functions would sometimes have to be reset together. The way we look
>> for the second function is:
>>
>> dev = pci_dev_get(dev1);
>> while ((dev = pci_get_device(vendor_id, device_id, dev))) {
>> if (dev->bus == dev1->bus &&
>> dev->devfn == dev1->devfn + 1) {
>> dev2 = dev;
>> break;
>> }
>> }
>>
>> I assume this is 'properly' since no-one has told me otherwise.
>
> As of right now, yes, this is the "correct" way to do this.
>
> I need to dig up the "let multiple drivers bind to a single device"
> patch set to make this not necessary in the future.
Ben and Greg, thanks.
--
Krzysztof Halasa
next prev parent reply other threads:[~2010-01-13 15:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 0:22 Can we remove pci_find_device() yet? Stephen Rothwell
2010-01-08 4:46 ` Greg KH
2010-01-11 19:46 ` Tilman Schmidt
2010-01-11 20:01 ` Greg KH
2010-01-12 0:21 ` Stephen Rothwell
2010-01-12 0:46 ` Greg KH
2010-01-12 16:42 ` Tilman Schmidt
2010-01-12 17:39 ` Greg KH
2010-01-13 9:02 ` Tilman Schmidt
2010-01-12 20:34 ` Krzysztof Halasa
2010-01-12 20:53 ` Ben Hutchings
2010-01-12 21:18 ` Greg KH
2010-01-13 15:09 ` Krzysztof Halasa [this message]
2010-01-13 14:23 ` [PATCH] pci: push deprecated pci_find_device() function to last user Tilman Schmidt
2010-01-14 4:33 ` David Miller
2010-01-14 4:43 ` Greg KH
2010-01-14 8:12 ` David Miller
2010-01-14 16:28 ` Jesse Barnes
2010-01-14 22:18 ` [PATCH/REPOST] " Tilman Schmidt
2010-01-15 18:08 ` Jesse Barnes
2010-01-16 11:17 ` Stephen Rothwell
2010-01-18 16:24 ` [PATCH/v2] " Tilman Schmidt
2010-01-14 10:18 ` Can we remove pci_find_device() yet? Andi Kleen
2010-01-14 11:02 ` Alan Cox
2010-01-14 11:03 ` Andi Kleen
2010-01-14 12:39 ` Tilman Schmidt
2010-01-20 15:11 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5pu6nzc.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=bhutchings@solarflare.com \
--cc=gregkh@suse.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox