From: Krzysztof Halasa <khc@pm.waw.pl>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Jeff Garzik <jeff@garzik.org>,
Russell King <rmk@arm.linux.org.uk>,
lkml <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
Date: Mon, 07 May 2007 13:56:41 +0200 [thread overview]
Message-ID: <m3r6psc0ee.fsf@maximus.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0705071318150.1479@scrub.home> (Roman Zippel's message of "Mon, 7 May 2007 13:22:40 +0200 (CEST)")
Roman Zippel <zippel@linux-m68k.org> writes:
>> You don't have to know it's required, you can just select a driver
>> for your hardware, without enabling HDLC first.
>
> Is this a real problem?
I think the "select" is better.
> Using select you should also consider removing HDLC as visible option and
> use only select. Mixing depends and selects is generally a bad idea.
It has to stay there for external modules.
It's similar to MII - drivers select MII automatically but you can
turn it on (Y or M) by hand as well.
And you can have HDLC=y and driver=m (and it makes perfect sense).
Actually I can't see any bad idea here.
The original dependency was certainly, uhm, not the best one.
--
Krzysztof Halasa
next prev parent reply other threads:[~2007-05-07 12:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-06 23:46 [PATCH 0/3] Intel IXP4xx network drivers Krzysztof Halasa
2007-05-07 0:06 ` [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" Krzysztof Halasa
2007-05-07 1:44 ` Roman Zippel
2007-05-07 9:35 ` Krzysztof Halasa
2007-05-07 11:22 ` Roman Zippel
2007-05-07 11:56 ` Krzysztof Halasa [this message]
2007-05-07 13:17 ` Roman Zippel
2007-05-07 13:21 ` Jeff Garzik
2007-05-07 13:46 ` Roman Zippel
2007-05-07 16:50 ` Krzysztof Halasa
2007-05-07 17:07 ` Roman Zippel
2007-05-07 18:15 ` Satyam Sharma
2007-05-07 20:31 ` Jeff Garzik
2007-05-07 20:49 ` Satyam Sharma
2007-05-07 20:50 ` Randy Dunlap
2007-05-07 22:39 ` Satyam Sharma
2007-05-07 22:52 ` Randy Dunlap
2007-05-07 20:57 ` Roman Zippel
2007-05-07 20:54 ` Krzysztof Halasa
2007-05-07 21:02 ` [PATCH] Use menuconfig objects II - netdev/wan Krzysztof Halasa
2007-05-07 21:08 ` [PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select" Krzysztof Halasa
2007-05-07 0:07 ` [PATCH 2/3] ARM: include IXP4xx "fuses" support Krzysztof Halasa
2007-05-07 5:24 ` Alexey Zaytsev
2007-05-07 10:24 ` Krzysztof Halasa
2007-05-07 0:07 ` [PATCH 3/3] Intel IXP4xx network drivers Krzysztof Halasa
2007-05-07 12:59 ` Michael-Luke Jones
2007-05-07 17:12 ` Krzysztof Halasa
2007-05-07 17:52 ` Christian Hohnstaedt
2007-05-07 20:00 ` Krzysztof Halasa
2007-05-08 11:48 ` Lennert Buytenhek
2007-05-08 13:47 ` Krzysztof Halasa
2007-05-07 18:14 ` Michael-Luke Jones
2007-05-07 19:57 ` Krzysztof Halasa
2007-05-07 20:18 ` Michael-Luke Jones
2007-05-08 11:46 ` Lennert Buytenhek
2007-05-08 0:11 ` [PATCH] Intel IXP4xx network drivers v.2 Krzysztof Halasa
2007-05-08 0:36 ` [PATCH] Intel IXP4xx network drivers v.2 - NPE Krzysztof Halasa
2007-05-08 7:02 ` Michael-Luke Jones
2007-05-08 13:56 ` Krzysztof Halasa
2007-05-08 0:46 ` [PATCH] Intel IXP4xx network drivers v.3 - QMGR Krzysztof Halasa
2007-05-08 7:05 ` Michael-Luke Jones
2007-05-08 13:57 ` Krzysztof Halasa
2007-05-08 11:32 ` Lennert Buytenhek
2007-05-08 12:47 ` Alexey Zaytsev
2007-05-08 12:59 ` Lennert Buytenhek
2007-05-08 14:12 ` Krzysztof Halasa
2007-05-08 14:40 ` Lennert Buytenhek
2007-05-08 16:59 ` Krzysztof Halasa
2007-05-09 10:21 ` Lennert Buytenhek
2007-05-10 14:08 ` Krzysztof Halasa
2007-05-08 1:19 ` [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS Krzysztof Halasa
2007-05-08 5:28 ` Jeff Garzik
2007-05-08 7:22 ` Michael-Luke Jones
2007-05-08 11:37 ` Lennert Buytenhek
2007-05-08 14:31 ` Krzysztof Halasa
2007-05-08 14:53 ` Lennert Buytenhek
2007-05-08 17:17 ` Krzysztof Halasa
2007-05-08 11:40 ` [PATCH 3/3] Intel IXP4xx network drivers Lennert Buytenhek
2007-05-07 10:27 ` [PATCH 2a/3] " Krzysztof Halasa
2007-05-08 1:40 ` [PATCH 0/3] " Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r6psc0ee.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=jeff@garzik.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).