netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: Walt Holman <walt@holmansrus.com>
Cc: David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Strange network timeouts w/ 2.6.30.5
Date: Thu, 20 Aug 2009 15:45:21 +0200	[thread overview]
Message-ID: <m3skfmk39q.fsf@intrepid.localdomain> (raw)
In-Reply-To: <985009134.71250769263099.JavaMail.root@mail.holmansrus.com> (Walt Holman's message of "Thu\, 20 Aug 2009 06\:54\:23 -0500 \(CDT\)")

Walt Holman <walt@holmansrus.com> writes:

> dmesg is attached. This box does have >2GB Ram (6GB total).  The dmesg
> will show e100 init'd 3 times since the first is the stock modprobe,
> 2nd was forced with use_io and the 3rd modprobe was after reverting
> the patch.

You most probably can't test without swiotlb (RAM has to be limited to
2 GB or so), can you? That would (dis)prove my theory. Alternatively (or
better), a test on IOMMU-equipped system would do.

Since swiotlb is x86-only thing (though other 64-bit archs may have
something similar), I think the correct work around is to enable the
"for_device" handoff on !X86.

Something like maybe:

Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 014dfb6..b610088 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -1762,9 +1762,12 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
 
 			if (ioread8(&nic->csr->scb.status) & rus_no_res)
 				nic->ru_running = RU_SUSPENDED;
+#ifndef CONFIG_X86
+		/* FIXME interferes with swiotlb. */
 		pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr,
 					       sizeof(struct rfd),
 					       PCI_DMA_BIDIRECTIONAL);
+#endif
 		return -ENODATA;
 	}
 
-- 
Krzysztof Halasa

  reply	other threads:[~2009-08-20 13:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1359163732.51250769223038.JavaMail.root@mail.holmansrus.com>
2009-08-20 11:54 ` Strange network timeouts w/ 2.6.30.5 Walt Holman
2009-08-20 13:45   ` Krzysztof Halasa [this message]
2009-08-20 19:28     ` David Miller
2009-08-20 20:28       ` Krzysztof Halasa
2009-08-20 22:21     ` Walt Holman
2009-08-21  9:44       ` Krzysztof Halasa
2009-08-23 19:18     ` Aviv Greenberg
2009-08-23 20:02       ` Krzysztof Halasa
     [not found] <1489093361.01250869377567.JavaMail.root@mail.holmansrus.com>
2009-08-21 15:45 ` Walt Holman
2009-08-22 20:26   ` Krzysztof Halasa
     [not found] <1762204735.01250727555803.JavaMail.root@mail.holmansrus.com>
     [not found] ` <2087985663.21250727676944.JavaMail.root@mail.holmansrus.com>
2009-08-20  4:17   ` David Miller
2009-08-20  9:03     ` Krzysztof Halasa
2009-08-20  9:13       ` David Miller
2009-08-20  9:22         ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3skfmk39q.fsf@intrepid.localdomain \
    --to=khc@pm.waw.pl \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=walt@holmansrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).