From: Krzysztof Halasa <khc@pm.waw.pl>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: Pekka J Enberg <penberg@cs.helsinki.fi>,
davem@davemloft.net, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: net: generic netdev_ioaddr
Date: Fri, 29 Oct 2004 23:13:24 +0200 [thread overview]
Message-ID: <m3u0sdb53f.fsf@defiant.pm.waw.pl> (raw)
In-Reply-To: <20041029193827.GV24336@parcelfarce.linux.theplanet.co.uk> (Al Viro's message of "Fri, 29 Oct 2004 20:38:27 +0100")
Al Viro <viro@parcelfarce.linux.theplanet.co.uk> writes:
> What uses ->base_addr from the data returned by SIOCGIFMAP?
ifconfig I think:
eth0 Link encap:Ethernet HWaddr 00:50:BA:70:68:3E
inet addr:10.0.0.2 Bcast:10.0.0.255 Mask:255.255.255.0
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:2796430 errors:1 dropped:0 overruns:0 frame:0
TX packets:4056563 errors:3 dropped:0 overruns:0 carrier:3
collisions:0 txqueuelen:1000
RX bytes:285233613 (272.0 Mb) TX bytes:1252627624 (1194.5 Mb)
Interrupt:10 Base address:0x4000
With this driver it happens to be MMIO address.
I understand presenting this value to users might have some value:
it can help determine the physical port/card for a given netdev.
But it should be something like a description text set by the driver
(ie. containing PCI bus/device, or even ISA address for ISA non-PnP
card, possibly with other information).
It seems while some devices use SIOCGIFMAP (ie. by setting the fields
in netdev struct), support for SIOCSIFMAP doesn't make sense for most
hardware.
Drivers using SIOCSIFMAP (selecting media only?):
arch/cris/arch-v10/drivers/ethernet.c: dev->set_config = e100_set_config;
drivers/net/au1000_eth.c: dev->set_config = &au1000_set_config;
drivers/net/sis900.c: net_dev->set_config = &sis900_set_config;
drivers/net/arm/etherh.c: dev->set_config = etherh_set_config;
drivers/net/pcmcia/3c589_cs.c: dev->set_config = &el3_config;
drivers/net/pcmcia/fmvj18x_cs.c: dev->set_config = &fjn_config;
drivers/net/pcmcia/nmclan_cs.c: dev->set_config = &mace_config;
drivers/net/pcmcia/pcnet_cs.c: dev->set_config = &set_config;
drivers/net/pcmcia/smc91c92_cs.c: dev->set_config = &s9k_config;
drivers/net/pcmcia/xirc2ps_cs.c: dev->set_config = &do_config;
drivers/net/wan/sdla.c: dev->set_config = sdla_set_config;
drivers/net/wireless/ray_cs.c: dev->set_config = &ray_dev_config;
I think I would mark this stuff obsolete, and remove when the drivers
are updated (if they need an update at all, they may support
ethtool/mii-tool already).
--
Krzysztof Halasa
next prev parent reply other threads:[~2004-10-29 21:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 10:04 [RFC][PATCH 0/3] net: generic netdev_ioaddr Pekka Enberg
2004-10-29 10:04 ` [PATCH 1/3] " Pekka Enberg
2004-10-29 10:05 ` [PATCH 2/3] net: use netdev_ioaddr in natsemi Pekka Enberg
2004-10-29 10:05 ` [PATCH 3/3] net: use netdev_ioaddr in 8139too Pekka Enberg
2004-10-29 11:52 ` [RFC][PATCH 0/3] net: generic netdev_ioaddr Christoph Hellwig
2004-10-29 13:16 ` Al Viro
2004-10-29 18:50 ` Pekka J Enberg
2004-10-29 19:18 ` Krzysztof Halasa
2004-10-29 19:38 ` Al Viro
2004-10-29 21:13 ` Krzysztof Halasa [this message]
2004-10-30 9:52 ` Pekka Enberg
2004-10-31 1:02 ` Krzysztof Halasa
2004-10-31 7:11 ` Pekka Enberg
2004-10-31 23:14 ` Krzysztof Halasa
2004-11-01 14:27 ` Pekka Enberg
2004-10-29 20:01 ` [PATCH] net: fix natsemi base_addr casting Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u0sdb53f.fsf@defiant.pm.waw.pl \
--to=khc@pm.waw.pl \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=penberg@cs.helsinki.fi \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).